From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8872 invoked by alias); 13 Dec 2011 20:45:43 -0000 Received: (qmail 8862 invoked by uid 22791); 13 Dec 2011 20:45:40 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Dec 2011 20:45:28 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBDKjEfU022468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Dec 2011 15:45:14 -0500 Received: from host2.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBDKj54i001908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 13 Dec 2011 15:45:09 -0500 Date: Tue, 13 Dec 2011 21:10:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Use symbol search name in expand_symtabs_matching_via_partial... Message-ID: <20111213204504.GA7129@host2.jankratochvil.net> References: <1323808430-18660-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1323808430-18660-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00423.txt.bz2 On Tue, 13 Dec 2011 21:33:50 +0100, Joel Brobecker wrote: > In C++, that does not make a difference, but it does in > Ada, because Ada searches using the symbol encoded name... That is more your Ada decision then... > --- a/gdb/psymtab.c > +++ b/gdb/psymtab.c > @@ -1305,7 +1305,7 @@ expand_symtabs_matching_via_partial > || (kind == TYPES_DOMAIN > && SYMBOL_CLASS (*psym) == LOC_TYPEDEF)) > && (*name_matcher) (current_language, > - SYMBOL_NATURAL_NAME (*psym), data)) > + SYMBOL_SEARCH_NAME (*psym), data)) It will need the same change for .gdb_index in write_psymbols. It would also mean .gdb_index version should be increased and backward compatibility implemented although IMHO it can be ignored for Ada, not sure if Ada users deploy .gdb_index. Thanks, Jan