Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: [commit] testsuite: KFAIL gdb.cp/static-method.exp  [Re: Regression for gdb.base/sigstep.exp with .debug_types]
Date: Sat, 10 Dec 2011 19:27:00 -0000	[thread overview]
Message-ID: <20111210160145.GA7261@host2.jankratochvil.net> (raw)
In-Reply-To: <20111209215319.GA5132@host2.jankratochvil.net>

On Fri, 09 Dec 2011 22:53:19 +0100, Jan Kratochvil wrote:
> Going to file it to GCC debug/ .  I believe with proper GCC debug/ it would
> work.  Not sure now why it worked before but it probably does not matter.

Doug has notified me it is an existing GCC PR debug/45682, it even has
a workaround in GDB but that workaround is not applicable in this case [see
the testsuite comment].

Therefore KFAILed it.  (Not sure if it should be XFAIL or KFAIl but it does
not matter much.)

Checked in.  Tested on x86_64-fedora16-linux-gnu.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-12/msg00083.html

--- src/gdb/testsuite/ChangeLog	2011/12/10 15:16:35	1.2974
+++ src/gdb/testsuite/ChangeLog	2011/12/10 15:58:14	1.2975
@@ -1,3 +1,13 @@
+2011-12-10  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.cp/static-method.exp (have_gcc_45682_fixed, info addr A::func()):
+	New variable, new test.
+	(list static-method.cc:xxx::(anonymous namespace)::A::func)
+	(list 'static-method.cc:xxx::(anonymous namespace)::A::func')
+	(list 'static-method.cc':'xxx::(anonymous namespace)::A::func')
+	(list static-method.cc:'xxx::(anonymous namespace)::A::func'): KFAIL
+	them if HAVE_GCC_45682_FIXED is not set.
+
 2011-12-10  Yao Qi  <yao@codesourcery.com>
 
 	* gdb.trace/status-stop.exp: New.
--- src/gdb/testsuite/gdb.cp/static-method.exp	2011/07/18 15:15:06	1.2
+++ src/gdb/testsuite/gdb.cp/static-method.exp	2011/12/10 15:58:14	1.3
@@ -48,6 +48,23 @@
     return -1
 }
 
+# The GDB workaround for GCC PR debug/45682 does not apply as it requires
+# DW_AT_linkage_name of methods.  The whole class A is in anonymous namespace,
+# therefore not accessible outside of the CU (compilation unit) and therefore
+# GCC does not produce DW_AT_linkage_name for such methods.
+
+set have_gcc_45682_fixed 1
+set test "info addr A::func()"
+gdb_test_multiple $test $test {
+    -re "No symbol \"A::func\\(\\)\" in current context\\.\r\n$gdb_prompt $" {
+	pass $test
+    }
+    -re "Symbol \"A::func\\(\\)\" is a function at address .*\r\n$gdb_prompt $" {
+	kfail gcc/45682 $test
+	set have_gcc_45682_fixed 0
+    }
+}
+
 if {![runto_main]} {
     perror "couldn't run to breakpoint"
     continue
@@ -68,9 +85,25 @@
 
     # Test whether the function/method can be "list"ed
     # with the filename pre-pended.
+    if {[string compare $test "xxx::${ans}::A::func"] == 0
+	&& !$have_gcc_45682_fixed} {
+	setup_kfail gcc/45682 "*-*-*"
+    }
     gdb_test "list ${srcfile}:$test" $result
+    if {[string compare $test "xxx::${ans}::A::func"] == 0
+	&& !$have_gcc_45682_fixed} {
+	setup_kfail gcc/45682 "*-*-*"
+    }
     gdb_test "list '${srcfile}:$test'" $result
+    if {[string compare $test "xxx::${ans}::A::func"] == 0
+	&& !$have_gcc_45682_fixed} {
+	setup_kfail gcc/45682 "*-*-*"
+    }
     gdb_test "list '${srcfile}':'$test'" $result
+    if {[string compare $test "xxx::${ans}::A::func"] == 0
+	&& !$have_gcc_45682_fixed} {
+	setup_kfail gcc/45682 "*-*-*"
+    }
     gdb_test "list ${srcfile}:'$test'" $result
 
     # Test setting and hitting a breakoint at the function/method.


  parent reply	other threads:[~2011-12-10 16:02 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05  8:19 creating the gdb-7.4 branch tomorrow (?) Joel Brobecker
2011-12-06 18:45 ` Tom Tromey
2011-12-06 18:53 ` Tom Tromey
2011-12-06 18:54 ` Tom Tromey
2011-12-06 19:05 ` Tom Tromey
2011-12-06 19:05 ` Tom Tromey
2011-12-06 19:07 ` Tom Tromey
2011-12-06 19:10 ` Tom Tromey
2011-12-07  4:09   ` Hui Zhu
2011-12-07  9:54     ` Joel Brobecker
2011-12-07 16:24       ` Stan Shebs
2011-12-07 23:50       ` Stan Shebs
2011-12-08  8:22         ` Joel Brobecker
2011-12-07  9:11   ` Jan Kratochvil
2011-12-07 10:01     ` Joel Brobecker
2011-12-08 15:33     ` FYI: fixlet in ovsrch.exp (Was: creating the gdb-7.4 branch tomorrow (?)) Tom Tromey
2011-12-09 17:17   ` Crash regression for gdb.base/ending-run.exp [Re: creating the gdb-7.4 branch tomorrow (?)] Jan Kratochvil
2011-12-09 19:05     ` Tom Tromey
2011-12-09 21:00       ` Jan Kratochvil
2011-12-09 17:17   ` Regression for gdb.base/sigstep.exp with .debug_types " Jan Kratochvil
2011-12-09 17:26     ` Regression for gdb.base/sigstep.exp with .debug_types Jan Kratochvil
2011-12-09 20:50       ` Tom Tromey
2011-12-09 21:55         ` Jan Kratochvil
2011-12-10  9:46           ` Tom Tromey
2011-12-10 19:27           ` Jan Kratochvil [this message]
2011-12-11  9:26             ` [commit] testsuite: KFAIL gdb.cp/static-method.exp [Re: Regression for gdb.base/sigstep.exp with .debug_types] Joel Brobecker
2011-12-11 12:42               ` Jan Kratochvil
2011-12-11 12:46                 ` Joel Brobecker
2011-12-14 19:02                   ` [patch] gcc KFAILs to XFAILs [Re: [commit] testsuite: KFAIL gdb.cp/static-method.exp] Jan Kratochvil
2011-12-14 19:43                     ` Doug Evans
2011-12-14 19:51                       ` [doc patch] gdbint: XFAIL vs. KFAIL [Re: [patch] gcc KFAILs to XFAILs] Jan Kratochvil
2011-12-15  5:33                         ` Eli Zaretskii
2011-12-19 11:16                           ` Jan Kratochvil
2011-12-19 13:41                             ` Eli Zaretskii
2011-12-19 13:42                               ` [commit] " Jan Kratochvil
2011-12-19 13:43                     ` [commit] [patch] gcc KFAILs to XFAILs [Re: [commit] testsuite: KFAIL gdb.cp/static-method.exp] Jan Kratochvil
2011-12-09 20:17     ` Regression for gdb.base/sigstep.exp with .debug_types [Re: creating the gdb-7.4 branch tomorrow (?)] Tom Tromey
2011-12-09 20:20       ` Jan Kratochvil
2011-12-14 11:52   ` creating the gdb-7.4 branch tomorrow (?) Andreas Schwab
2011-12-14 13:20     ` Joel Brobecker
2011-12-14 13:34       ` Andreas Schwab
2011-12-14 19:28     ` Joel Brobecker
2011-12-14 21:16       ` Andreas Schwab
2011-12-14 21:31         ` Joel Brobecker
2011-12-14 22:06           ` Andreas Schwab
2011-12-15 17:43       ` Tom Tromey
2012-07-22 19:41   ` Andreas Schwab
2012-08-15 19:34     ` Tom Tromey
2012-08-22 14:23       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111210160145.GA7261@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox