[rfa, s390] [bfd part] Support extended register sets

[rfa, s390] [bfd part] Support extended register sets

[Ulrich Weigand]

Hello,

recent Linux kernels have added two new core file note types that are
not yet supported in BFD.  The patch below adds those to elf/common.h,
and also provided support for reading/writing them, to be used by GDB.

Tested (together with the GDB patch) on s390x-ibm-linux (31-bit and
64-bit) and s390-ibm-linux.

OK for BFD mainline?

Bye,
Ulrich


include/elf/ChangeLog:

	* common.h (NT_S390_LAST_BREAK): Define.
	(NT_S390_SYSTEM_CALL): Likewise.

bfd/ChangeLog:

	* elf-bfd.h (elfcore_write_s390_last_break): Add prototype.
	(elfcore_write_s390_system_call): Likewise.
	* elf.c (elfcore_write_s390_last_break): New function.
	(elfcore_write_s390_system_call): Likewise.
	(elfcore_write_register_note): Call them.
	(elfcore_grok_s390_last_break): New function.
	(elfcore_grok_s390_system_call): Likewise.
	(elfcore_grok_note): Call them.


Index: gdb-head/bfd/elf-bfd.h
===================================================================
--- gdb-head.orig/bfd/elf-bfd.h
+++ gdb-head/bfd/elf-bfd.h
@@ -2237,6 +2237,10 @@ extern char *elfcore_write_s390_ctrs
   (bfd *, char *, int *, const void *, int);
 extern char *elfcore_write_s390_prefix
   (bfd *, char *, int *, const void *, int);
+extern char *elfcore_write_s390_last_break
+  (bfd *, char *, int *, const void *, int);
+extern char *elfcore_write_s390_system_call
+  (bfd *, char *, int *, const void *, int);
 extern char *elfcore_write_arm_vfp
   (bfd *, char *, int *, const void *, int);
 extern char *elfcore_write_lwpstatus
Index: gdb-head/bfd/elf.c
===================================================================
--- gdb-head.orig/bfd/elf.c
+++ gdb-head/bfd/elf.c
@@ -7983,6 +7983,18 @@ elfcore_grok_s390_prefix (bfd *abfd, Elf
 }
 
 static bfd_boolean
+elfcore_grok_s390_last_break (bfd *abfd, Elf_Internal_Note *note)
+{
+  return elfcore_make_note_pseudosection (abfd, ".reg-s390-last-break", note);
+}
+
+static bfd_boolean
+elfcore_grok_s390_system_call (bfd *abfd, Elf_Internal_Note *note)
+{
+  return elfcore_make_note_pseudosection (abfd, ".reg-s390-system-call", note);
+}
+
+static bfd_boolean
 elfcore_grok_arm_vfp (bfd *abfd, Elf_Internal_Note *note)
 {
   return elfcore_make_note_pseudosection (abfd, ".reg-arm-vfp", note);
@@ -8407,6 +8419,20 @@ elfcore_grok_note (bfd *abfd, Elf_Intern
       else
         return TRUE;
 
+    case NT_S390_LAST_BREAK:
+      if (note->namesz == 6
+          && strcmp (note->namedata, "LINUX") == 0)
+        return elfcore_grok_s390_last_break (abfd, note);
+      else
+        return TRUE;
+
+    case NT_S390_SYSTEM_CALL:
+      if (note->namesz == 6
+          && strcmp (note->namedata, "LINUX") == 0)
+        return elfcore_grok_s390_system_call (abfd, note);
+      else
+        return TRUE;
+
     case NT_ARM_VFP:
       if (note->namesz == 6
 	  && strcmp (note->namedata, "LINUX") == 0)
@@ -9168,6 +9194,32 @@ elfcore_write_s390_prefix (bfd *abfd,
 }
 
 char *
+elfcore_write_s390_last_break (bfd *abfd,
+			       char *buf,
+			       int *bufsiz,
+			       const void *s390_last_break,
+			       int size)
+{
+  char *note_name = "LINUX";
+  return elfcore_write_note (abfd, buf, bufsiz,
+                             note_name, NT_S390_LAST_BREAK,
+			     s390_last_break, size);
+}
+
+char *
+elfcore_write_s390_system_call (bfd *abfd,
+				char *buf,
+				int *bufsiz,
+				const void *s390_system_call,
+				int size)
+{
+  char *note_name = "LINUX";
+  return elfcore_write_note (abfd, buf, bufsiz,
+                             note_name, NT_S390_SYSTEM_CALL,
+			     s390_system_call, size);
+}
+
+char *
 elfcore_write_arm_vfp (bfd *abfd,
 		       char *buf,
 		       int *bufsiz,
@@ -9209,6 +9261,10 @@ elfcore_write_register_note (bfd *abfd,
     return elfcore_write_s390_ctrs (abfd, buf, bufsiz, data, size);
   if (strcmp (section, ".reg-s390-prefix") == 0)
     return elfcore_write_s390_prefix (abfd, buf, bufsiz, data, size);
+  if (strcmp (section, ".reg-s390-last-break") == 0)
+    return elfcore_write_s390_last_break (abfd, buf, bufsiz, data, size);
+  if (strcmp (section, ".reg-s390-system-call") == 0)
+    return elfcore_write_s390_system_call (abfd, buf, bufsiz, data, size);
   if (strcmp (section, ".reg-arm-vfp") == 0)
     return elfcore_write_arm_vfp (abfd, buf, bufsiz, data, size);
   return NULL;
Index: gdb-head/include/elf/common.h
===================================================================
--- gdb-head.orig/include/elf/common.h
+++ gdb-head/include/elf/common.h
@@ -543,6 +543,10 @@
 					/*   note name must be "LINUX".  */
 #define NT_S390_PREFIX	0x305		/* S390 prefix register */
 					/*   note name must be "LINUX".  */
+#define NT_S390_LAST_BREAK      0x306   /* S390 breaking event address */
+					/*   note name must be "LINUX".  */
+#define NT_S390_SYSTEM_CALL     0x307   /* S390 system call restart data */
+					/*   note name must be "LINUX".  */
 #define NT_ARM_VFP	0x400		/* ARM VFP registers */
 					/*   note name must be "LINUX".  */
 
-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: [rfa, s390] [bfd part] Support extended register sets

[Alan Modra]

On Thu, Dec 01, 2011 at 04:37:14PM +0100, Ulrich Weigand wrote:
> include/elf/ChangeLog:
> 
> 	* common.h (NT_S390_LAST_BREAK): Define.
> 	(NT_S390_SYSTEM_CALL): Likewise.
> 
> bfd/ChangeLog:
> 
> 	* elf-bfd.h (elfcore_write_s390_last_break): Add prototype.
> 	(elfcore_write_s390_system_call): Likewise.
> 	* elf.c (elfcore_write_s390_last_break): New function.
> 	(elfcore_write_s390_system_call): Likewise.
> 	(elfcore_write_register_note): Call them.
> 	(elfcore_grok_s390_last_break): New function.
> 	(elfcore_grok_s390_system_call): Likewise.
> 	(elfcore_grok_note): Call them.

OK.

-- 
Alan Modra
Australia Development Lab, IBM

Re: [rfa, s390] [bfd part] Support extended register sets

[Ulrich Weigand]

Alan Modra wrote:
> On Thu, Dec 01, 2011 at 04:37:14PM +0100, Ulrich Weigand wrote:
> > include/elf/ChangeLog:
> > 
> > 	* common.h (NT_S390_LAST_BREAK): Define.
> > 	(NT_S390_SYSTEM_CALL): Likewise.
> > 
> > bfd/ChangeLog:
> > 
> > 	* elf-bfd.h (elfcore_write_s390_last_break): Add prototype.
> > 	(elfcore_write_s390_system_call): Likewise.
> > 	* elf.c (elfcore_write_s390_last_break): New function.
> > 	(elfcore_write_s390_system_call): Likewise.
> > 	(elfcore_write_register_note): Call them.
> > 	(elfcore_grok_s390_last_break): New function.
> > 	(elfcore_grok_s390_system_call): Likewise.
> > 	(elfcore_grok_note): Call them.
> 
> OK.

Thanks, Alan!  I've checked this in now.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com