From: Pedro Alves <pedro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [2/3] RFC: *stopped and CLI commands
Date: Tue, 22 Nov 2011 20:48:00 -0000 [thread overview]
Message-ID: <201111222047.47204.pedro@codesourcery.com> (raw)
In-Reply-To: <m3bos33oua.fsf@fleche.redhat.com>
On Tuesday 22 November 2011 20:05:17, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
> Pedro> Hmm, I should have read this one first. This means that with
> Pedro> patch 3 we'll print "Stopped due to ..." twice?
>
> Yes, I hadn't noticed that. Oops.
>
> However, we still need this call in order to get the reason= output in
> the MI notification when the command was a CLI command. That is, if you
> omit this call, you get:
...
> Note how the *stopped doesn't have a reason.
>
> The fix is to leave this call to bpstat_print, but to change the
> printing of "Stopped due to shared library event" to use ui_out_text
> rather than printf_filtered. This eliminates the double printing.
Yeah, makes sense.
--
Pedro Alves
prev parent reply other threads:[~2011-11-22 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 20:00 Tom Tromey
2011-11-22 15:08 ` Pedro Alves
2011-11-22 20:05 ` Tom Tromey
2011-11-22 20:48 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111222047.47204.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox