From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23204 invoked by alias); 22 Nov 2011 20:48:05 -0000 Received: (qmail 23196 invoked by uid 22791); 22 Nov 2011 20:48:05 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 20:47:52 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RSxFv-0001iU-8W from pedro_alves@mentor.com ; Tue, 22 Nov 2011 12:47:51 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 22 Nov 2011 20:47:50 +0000 From: Pedro Alves To: Tom Tromey Subject: Re: [2/3] RFC: *stopped and CLI commands Date: Tue, 22 Nov 2011 20:48:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201111221508.30259.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201111222047.47204.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00606.txt.bz2 On Tuesday 22 November 2011 20:05:17, Tom Tromey wrote: > >>>>> "Pedro" == Pedro Alves writes: > Pedro> Hmm, I should have read this one first. This means that with > Pedro> patch 3 we'll print "Stopped due to ..." twice? > > Yes, I hadn't noticed that. Oops. > > However, we still need this call in order to get the reason= output in > the MI notification when the command was a CLI command. That is, if you > omit this call, you get: ... > Note how the *stopped doesn't have a reason. > > The fix is to leave this call to bpstat_print, but to change the > printing of "Stopped due to shared library event" to use ui_out_text > rather than printf_filtered. This eliminates the double printing. Yeah, makes sense. -- Pedro Alves