Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Fix signal handler single step test on Sparc/Linux
@ 2011-11-16  6:15 David Miller
  2011-11-16 15:39 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2011-11-16  6:15 UTC (permalink / raw)
  To: gdb-patches


This target uses software single step, so we can't reliably step
into a signal handler.  Thus we shouldn't run tests such as
gdb.base/kill-after-signal.exp

Ok to commit?

gdb/testsuite/

2011-11-15  David S. Miller  <davem@davemloft.net>

	* lib/gdb.exp (can_single_step_to_signal_handler): Return zero when
	target is sparc*-*-linux

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 3f0bffd..5647172 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -1539,7 +1539,7 @@ proc can_single_step_to_signal_handler {} {
     # to determine the next instruction addresses, because start of signal
     # handler is one of them.
     if { [istarget "arm*-*-*"] || [istarget "mips*-*-*"]
-	 || [istarget "tic6x-*-*"] } {
+	 || [istarget "tic6x-*-*"] || [istarget "sparc*-*-linux"] } {
 	return 0
     }
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix signal handler single step test on Sparc/Linux
  2011-11-16  6:15 [PATCH] Fix signal handler single step test on Sparc/Linux David Miller
@ 2011-11-16 15:39 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2011-11-16 15:39 UTC (permalink / raw)
  To: David Miller; +Cc: gdb-patches

>>>>> "David" == David Miller <davem@davemloft.net> writes:

David> This target uses software single step, so we can't reliably step
David> into a signal handler.  Thus we shouldn't run tests such as
David> gdb.base/kill-after-signal.exp

David> Ok to commit?

David> gdb/testsuite/

David> 2011-11-15  David S. Miller  <davem@davemloft.net>

David> 	* lib/gdb.exp (can_single_step_to_signal_handler): Return zero when
David> 	target is sparc*-*-linux

This is ok.  Thanks.

Tom


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-16 15:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-16  6:15 [PATCH] Fix signal handler single step test on Sparc/Linux David Miller
2011-11-16 15:39 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox