From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Avoid calling gdb_realpath if basenames are different
Date: Mon, 07 Nov 2011 17:06:00 -0000 [thread overview]
Message-ID: <20111107170618.GH14508@adacore.com> (raw)
In-Reply-To: <20111106063053.B56F6246194@ruffy.mtv.corp.google.com>
> If people are concerned about breaking someone's usage,
> we could default basenames-may-differ to true in 7.4,
> with a warning that it will be set to false in 7.5 (or some such).
> [We could leave the default set to true, especially if someone knew
> of at least some minimally common usage this would break.
> I'd hate to otherwise penalize the vast majority of users if not.]
If it was my choice, I would go with setting it to false right now.
As you say, I think that the vast majority of people are going to
benefit from it immediately.
> 2011-11-05 Doug Evans <dje@google.com>
>
> * dwarf2read.c (dw2_lookup_symtab): Avoid calling gdb_realpath if
> ! basenames_may_differ.
> * psymtab.c (lookup_partial_symtab): Ditto.
> * symtab.c (lookup_partial_symtab): Ditto.
> * symtab.c (lookup_symtab): Ditto.
> (basenames_may_differ): New global.
> (_initialize_symtab): New parameter basenames-may-differ.
> * symtab.h (basenames_may_differ): Declare.
--
Joel
next prev parent reply other threads:[~2011-11-07 17:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 6:31 Doug Evans
2011-11-06 9:07 ` asmwarrior
2011-11-07 17:06 ` Joel Brobecker [this message]
2011-11-08 17:18 ` Tom Tromey
2011-11-11 0:57 ` [RFA, doc RFA] " Doug Evans
2011-11-11 8:49 ` Eli Zaretskii
2011-11-11 9:00 ` Doug Evans
2011-11-15 4:46 ` Doug Evans
2011-11-15 6:00 ` Eli Zaretskii
2011-11-15 14:23 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107170618.GH14508@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox