From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19665 invoked by alias); 7 Nov 2011 17:06:38 -0000 Received: (qmail 19656 invoked by uid 22791); 7 Nov 2011 17:06:38 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 17:06:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E88862BAB07; Mon, 7 Nov 2011 12:06:24 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id D4Ax1hUouI5h; Mon, 7 Nov 2011 12:06:24 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B3F682BAAFA; Mon, 7 Nov 2011 12:06:24 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EC958145615; Mon, 7 Nov 2011 12:06:18 -0500 (EST) Date: Mon, 07 Nov 2011 17:06:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Avoid calling gdb_realpath if basenames are different Message-ID: <20111107170618.GH14508@adacore.com> References: <20111106063053.B56F6246194@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111106063053.B56F6246194@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00159.txt.bz2 > If people are concerned about breaking someone's usage, > we could default basenames-may-differ to true in 7.4, > with a warning that it will be set to false in 7.5 (or some such). > [We could leave the default set to true, especially if someone knew > of at least some minimally common usage this would break. > I'd hate to otherwise penalize the vast majority of users if not.] If it was my choice, I would go with setting it to false right now. As you say, I think that the vast majority of people are going to benefit from it immediately. > 2011-11-05 Doug Evans > > * dwarf2read.c (dw2_lookup_symtab): Avoid calling gdb_realpath if > ! basenames_may_differ. > * psymtab.c (lookup_partial_symtab): Ditto. > * symtab.c (lookup_partial_symtab): Ditto. > * symtab.c (lookup_symtab): Ditto. > (basenames_may_differ): New global. > (_initialize_symtab): New parameter basenames-may-differ. > * symtab.h (basenames_may_differ): Declare. -- Joel