From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit/ia64-linux] Allow libunwind to fetch register 0
Date: Tue, 25 Oct 2011 20:49:00 -0000 [thread overview]
Message-ID: <20111025204052.GR19246@adacore.com> (raw)
In-Reply-To: <201110251818.43576.pedro@codesourcery.com>
Hi again Pedro,
I will make the small changes you suggested at the beginning of
the patch. I just wanted to confirm something:
> > + gdb_assert (sizeof (r0_value) == register_size (gdbarch, regnum));
> > + regcache_raw_supply (regcache, regnum, r0_value);
> > + return;
> > + }
> > +
>
> I don't speak ia64, but this is the right direction.
> I think we should make ia64_cannot_fetch_register return true for
> gr0 too though.
I assume that you mean that ia64_cannot_fetch_register should return
False as well (meaning that we can in fact fetch the register - don't
you love double negatives?). I had originally interpreted the name
of that function very strictly, meaning that, no, the kernel does
not provide that register value, so we cannot fetch it. But at the
same time, I think I see you point of having the fetch_register
routine saying we can get the value, while at the same time the
cannot_fetch_register function says we can't.
I will send a new patch...
--
Joel
next prev parent reply other threads:[~2011-10-25 20:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 16:55 Joel Brobecker
2011-10-25 17:27 ` Pedro Alves
2011-10-25 17:37 ` Pedro Alves
2011-10-25 20:49 ` Joel Brobecker [this message]
2011-10-26 0:27 ` Pedro Alves
2012-03-27 19:32 ` Pedro Alves
2012-03-27 23:03 ` Joel Brobecker
2012-03-28 12:52 ` Pedro Alves
2012-03-28 14:55 ` [PATCH] IA64: $fr0==0.0, $fr1==1.0 Pedro Alves
2012-03-28 17:15 ` Joel Brobecker
2012-03-28 17:56 ` Pedro Alves
2012-03-28 14:55 ` [PATCH] IA64: EC, the Epilog Count register, is available in ptrace Pedro Alves
2012-03-28 17:12 ` Joel Brobecker
2012-03-28 17:55 ` Pedro Alves
2012-03-28 17:10 ` [RFA/commit/ia64-linux] Allow libunwind to fetch register 0 Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025204052.GR19246@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox