From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21302 invoked by alias); 25 Oct 2011 20:41:11 -0000 Received: (qmail 21293 invoked by uid 22791); 25 Oct 2011 20:41:11 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Oct 2011 20:40:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4B8742BAEEC; Tue, 25 Oct 2011 16:40:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Sc4hf4NJdfRS; Tue, 25 Oct 2011 16:40:57 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0D8A82BAED6; Tue, 25 Oct 2011 16:40:56 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id CF2EA145615; Tue, 25 Oct 2011 16:40:52 -0400 (EDT) Date: Tue, 25 Oct 2011 20:49:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/ia64-linux] Allow libunwind to fetch register 0 Message-ID: <20111025204052.GR19246@adacore.com> References: <1319561563-20201-1-git-send-email-brobecker@adacore.com> <201110251818.43576.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201110251818.43576.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00685.txt.bz2 Hi again Pedro, I will make the small changes you suggested at the beginning of the patch. I just wanted to confirm something: > > + gdb_assert (sizeof (r0_value) == register_size (gdbarch, regnum)); > > + regcache_raw_supply (regcache, regnum, r0_value); > > + return; > > + } > > + > > I don't speak ia64, but this is the right direction. > I think we should make ia64_cannot_fetch_register return true for > gr0 too though. I assume that you mean that ia64_cannot_fetch_register should return False as well (meaning that we can in fact fetch the register - don't you love double negatives?). I had originally interpreted the name of that function very strictly, meaning that, no, the kernel does not provide that register value, so we cannot fetch it. But at the same time, I think I see you point of having the fetch_register routine saying we can get the value, while at the same time the cannot_fetch_register function says we can't. I will send a new patch... -- Joel