From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/RFC] try ignoring bad PLT entries in ELF symbol tables
Date: Fri, 21 Oct 2011 17:56:00 -0000 [thread overview]
Message-ID: <20111021173948.GA25280@host1.jankratochvil.net> (raw)
In-Reply-To: <20111021172958.GH19246@adacore.com>
On Fri, 21 Oct 2011 19:29:58 +0200, Joel Brobecker wrote:
> > Do you have some such file with undefinde symbol and non-zero value?
>
> Do you mean, other than on ia64-hpux?
You suggest the non-zero values are really random while I thought there could
be some coincidence what the value means. But it is true you would figure it
out yourself so we have to consider it as a random value.
> > > + if (strncmp (sect->name, ".plt", 4) != 0
> > > + && bfd_get_section_by_name (abfd, ".plt") != NULL)
> >
> > At least the bfd_get_section_by_name result should be cached.
>
> I didn't think it was going to make much of a difference,
OK, I agree it is better this way as the conditional is evaluated only for
very few ELF symbols, not for all ELF symbols.
Thanks,
Jan
next prev parent reply other threads:[~2011-10-21 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 0:30 Joel Brobecker
2011-10-20 20:00 ` Jan Kratochvil
2011-10-21 17:40 ` Joel Brobecker
2011-10-21 17:56 ` Jan Kratochvil [this message]
2011-12-01 23:14 ` Joel Brobecker
2011-12-19 4:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021173948.GA25280@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox