From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12658 invoked by alias); 21 Oct 2011 17:40:53 -0000 Received: (qmail 12647 invoked by uid 22791); 21 Oct 2011 17:40:52 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Oct 2011 17:40:30 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9LHdrYT004279 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Oct 2011 13:39:53 -0400 Received: from host1.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9LHdpPP019202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Oct 2011 13:39:52 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p9LHdoSA014267; Fri, 21 Oct 2011 19:39:50 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p9LHdnqY014252; Fri, 21 Oct 2011 19:39:49 +0200 Date: Fri, 21 Oct 2011 17:56:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/RFC] try ignoring bad PLT entries in ELF symbol tables Message-ID: <20111021173948.GA25280@host1.jankratochvil.net> References: <1318983817-29454-1-git-send-email-brobecker@adacore.com> <20111020194921.GA16613@host1.jankratochvil.net> <20111021172958.GH19246@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111021172958.GH19246@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00600.txt.bz2 On Fri, 21 Oct 2011 19:29:58 +0200, Joel Brobecker wrote: > > Do you have some such file with undefinde symbol and non-zero value? > > Do you mean, other than on ia64-hpux? You suggest the non-zero values are really random while I thought there could be some coincidence what the value means. But it is true you would figure it out yourself so we have to consider it as a random value. > > > + if (strncmp (sect->name, ".plt", 4) != 0 > > > + && bfd_get_section_by_name (abfd, ".plt") != NULL) > > > > At least the bfd_get_section_by_name result should be cached. > > I didn't think it was going to make much of a difference, OK, I agree it is better this way as the conditional is evaluated only for very few ELF symbols, not for all ELF symbols. Thanks, Jan