Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [commit] [patch] Fix crash on empty DWARF expressions NULL DATA vs. zero SIZE
Date: Wed, 12 Oct 2011 22:04:00 -0000	[thread overview]
Message-ID: <20111012220436.GA30417@host1.jankratochvil.net> (raw)
In-Reply-To: <20110713160435.GA19359@host1.jankratochvil.net>

On Wed, 13 Jul 2011 18:04:35 +0200, Jan Kratochvil wrote:
> gdb/
> 2011-07-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Fix empty DWARF expressions DATA vs. SIZE conditionals.
> 	* dwarf2loc.c (dwarf2_find_location_expression): Clear *LOCEXPR_LENGTH.
> 	(dwarf_expr_frame_base_1): Indicate unavailability via zero *LENGTH.
> 	(locexpr_tracepoint_var_ref): Check only zero SIZE, not zero DATA.
> 	(loclist_read_variable, loclist_tracepoint_var_ref): Do not check for
> 	zero DATA.
> 	* dwarf2loc.h (struct dwarf2_locexpr_baton): Comment DATA vs. SIZE
> 	validity.
> 	* dwarf2read.c (struct dwarf_block): Comment DATA validity.
> 	(dwarf2_fetch_die_location_block, dwarf2_symbol_mark_computed): Do not
> 	clear DATA on zero SIZE.
> 
> gdb/testsuite/
> 2011-07-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Fix empty DWARF expressions DATA vs. SIZE conditionals.
> 	* gdb.dwarf2/dw2-op-call.S (arraycallnoloc, arraynoloc): New DIEs.
> 	(loclist): New.
> 	(4): New abbrev.
> 	* gdb.dwarf2/dw2-op-call.exp: Remove variable srcfile and executable.
> 	Use prepare_for_testing, remove clean_restart.
> 	(p arraynoloc, p arraycallnoloc): New tests.

Checked in:
	http://sourceware.org/ml/gdb-cvs/2011-10/msg00104.html

With some new patches I found out I need again to find out whether a DWARF
block is <optimized out> and I remembered this patch of mine.


Thanks,
Jan


  reply	other threads:[~2011-10-12 22:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 17:03 Jan Kratochvil
2011-10-12 22:04 ` Jan Kratochvil [this message]
2011-10-13  8:05   ` [commit] " Yao Qi
2011-10-13  9:38     ` [obv] Fix warning: initialize unused field [Re: [commit] [patch] Fix crash on empty DWARF expressions NULL DATA vs. zero SIZE] Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111012220436.GA30417@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox