From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9242 invoked by alias); 12 Oct 2011 22:04:57 -0000 Received: (qmail 9230 invoked by uid 22791); 12 Oct 2011 22:04:56 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Oct 2011 22:04:39 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9CM4dTI010528 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Oct 2011 18:04:39 -0400 Received: from host1.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9CM4bCi032672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 12 Oct 2011 18:04:38 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p9CM4aof007145 for ; Thu, 13 Oct 2011 00:04:36 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p9CM4acW007144 for gdb-patches@sourceware.org; Thu, 13 Oct 2011 00:04:36 +0200 Date: Wed, 12 Oct 2011 22:04:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [commit] [patch] Fix crash on empty DWARF expressions NULL DATA vs. zero SIZE Message-ID: <20111012220436.GA30417@host1.jankratochvil.net> References: <20110713160435.GA19359@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110713160435.GA19359@host1.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00377.txt.bz2 On Wed, 13 Jul 2011 18:04:35 +0200, Jan Kratochvil wrote: > gdb/ > 2011-07-13 Jan Kratochvil > > Fix empty DWARF expressions DATA vs. SIZE conditionals. > * dwarf2loc.c (dwarf2_find_location_expression): Clear *LOCEXPR_LENGTH. > (dwarf_expr_frame_base_1): Indicate unavailability via zero *LENGTH. > (locexpr_tracepoint_var_ref): Check only zero SIZE, not zero DATA. > (loclist_read_variable, loclist_tracepoint_var_ref): Do not check for > zero DATA. > * dwarf2loc.h (struct dwarf2_locexpr_baton): Comment DATA vs. SIZE > validity. > * dwarf2read.c (struct dwarf_block): Comment DATA validity. > (dwarf2_fetch_die_location_block, dwarf2_symbol_mark_computed): Do not > clear DATA on zero SIZE. > > gdb/testsuite/ > 2011-07-13 Jan Kratochvil > > Fix empty DWARF expressions DATA vs. SIZE conditionals. > * gdb.dwarf2/dw2-op-call.S (arraycallnoloc, arraynoloc): New DIEs. > (loclist): New. > (4): New abbrev. > * gdb.dwarf2/dw2-op-call.exp: Remove variable srcfile and executable. > Use prepare_for_testing, remove clean_restart. > (p arraynoloc, p arraycallnoloc): New tests. Checked in: http://sourceware.org/ml/gdb-cvs/2011-10/msg00104.html With some new patches I found out I need again to find out whether a DWARF block is and I remembered this patch of mine. Thanks, Jan