From: David Miller <davem@davemloft.net>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix jit.exp on most 32-bit targets.
Date: Tue, 11 Oct 2011 19:12:00 -0000 [thread overview]
Message-ID: <20111011.151141.2005206627187628853.davem@davemloft.net> (raw)
In-Reply-To: <m3pqi3a4fs.fsf@fleche.redhat.com>
From: Tom Tromey <tromey@redhat.com>
Date: Tue, 11 Oct 2011 10:17:11 -0600
>>>>>> "David" == David Miller <davem@davemloft.net> writes:
>
> David> 2011-10-10 David S. Miller <davem@davemloft.net>
> David> * gdbarch.sh: New field 'long_long_align_bit'.
> David> * gdbarch.c, gdbarch.h: Regenerate.
> David> * i386-tdep.c (i386_gdbarch_init): Set long_long_align_bit to 32.
> David> * jit.c (jit_read_code_entry): Use it to determine correct size offset.
>
> Ok. Thanks.
Thanks for reviewing.
We're going to have to, at some point, have gdb be able to properly
lay out structures, unions, and other data structures, as well as do
the work of passing arguments and receiving return values,
generically. And this is a sort-of micro-step in that direction.
And once we have such generic facilities, bugs like this JIT thing
won't even be possible. :-)
next prev parent reply other threads:[~2011-10-11 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 2:59 David Miller
2011-10-11 9:30 ` Mark Kettenis
2011-10-11 16:18 ` Tom Tromey
2011-10-11 16:48 ` Tom Tromey
2011-10-11 19:12 ` David Miller [this message]
2011-10-11 19:20 ` Tom Tromey
2011-10-11 19:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011.151141.2005206627187628853.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox