From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13081 invoked by alias); 11 Oct 2011 19:12:08 -0000 Received: (qmail 13073 invoked by uid 22791); 11 Oct 2011 19:12:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (198.137.202.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Oct 2011 19:11:49 +0000 Received: from localhost (nat-pool-rdu.redhat.com [66.187.233.202]) (authenticated bits=0) by shards.monkeyblade.net (8.14.4/8.14.4) with ESMTP id p9BJBfln026319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Oct 2011 12:11:44 -0700 Date: Tue, 11 Oct 2011 19:12:00 -0000 Message-Id: <20111011.151141.2005206627187628853.davem@davemloft.net> To: tromey@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix jit.exp on most 32-bit targets. From: David Miller In-Reply-To: References: <20111010.225847.435074482632472630.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00325.txt.bz2 From: Tom Tromey Date: Tue, 11 Oct 2011 10:17:11 -0600 >>>>>> "David" == David Miller writes: > > David> 2011-10-10 David S. Miller > David> * gdbarch.sh: New field 'long_long_align_bit'. > David> * gdbarch.c, gdbarch.h: Regenerate. > David> * i386-tdep.c (i386_gdbarch_init): Set long_long_align_bit to 32. > David> * jit.c (jit_read_code_entry): Use it to determine correct size offset. > > Ok. Thanks. Thanks for reviewing. We're going to have to, at some point, have gdb be able to properly lay out structures, unions, and other data structures, as well as do the work of passing arguments and receiving return values, generically. And this is a sort-of micro-step in that direction. And once we have such generic facilities, bugs like this JIT thing won't even be possible. :-)