From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: brobecker@adacore.com (Joel Brobecker)
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com (Jan Kratochvil)
Subject: Re: [RFA] fetch result of locdesc expressions as integer (not address)
Date: Tue, 04 Oct 2011 23:06:00 -0000 [thread overview]
Message-ID: <201110042305.p94N5qTW011596@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20111004193739.GM19246@adacore.com> from "Joel Brobecker" at Oct 04, 2011 12:37:39 PM
Joel Brobecker wrote:
> > It seems the problem is a bit more complex: different callers
> > of decode_locdesc have different expectations. As the comment
> > before the routine says:
> >
> > NOTE drow/2003-11-18: This function is called in two situations
> > now: for the address of static or global variables (partial symbols
> > only) and for offsets into structures which are expected to be
> > (more or less) constant.
>
> That's true, but my interpretation was the callers of decode_locdesc
> should know which they expect it to me, and thus know to apply
> the integer_to_address correction.
Well, maybe they should, but right now they don't, and neither does
your patch add any such correction. The point I was trying to make
is that therefore, your patch as it is, while fixing one class of
bugs on some targets, may simultaneously introduce a different class
of bugs on other targets. I'm not sure this is a good idea ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-10-04 23:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 21:10 Joel Brobecker
2011-10-04 17:16 ` Tom Tromey
2011-10-04 19:32 ` Ulrich Weigand
2011-10-04 19:38 ` Joel Brobecker
2011-10-04 23:06 ` Ulrich Weigand [this message]
2011-10-05 1:09 ` Joel Brobecker
2011-10-05 12:30 ` Ulrich Weigand
2011-10-09 16:35 ` [patch#2] " Jan Kratochvil
2011-10-17 1:56 ` Joel Brobecker
2011-10-17 7:59 ` Tristan Gingold
2011-10-17 13:22 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110042305.p94N5qTW011596@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox