From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [RFA] fetch result of locdesc expressions as integer (not address)
Date: Tue, 04 Oct 2011 19:38:00 -0000 [thread overview]
Message-ID: <20111004193739.GM19246@adacore.com> (raw)
In-Reply-To: <201110041931.p94JVr9R028400@d06av02.portsmouth.uk.ibm.com>
> It seems the problem is a bit more complex: different callers
> of decode_locdesc have different expectations. As the comment
> before the routine says:
>
> NOTE drow/2003-11-18: This function is called in two situations
> now: for the address of static or global variables (partial symbols
> only) and for offsets into structures which are expected to be
> (more or less) constant.
That's true, but my interpretation was the callers of decode_locdesc
should know which they expect it to me, and thus know to apply
the integer_to_address correction.
> Maybe we ought to have two routines (or a parameter) here.
I think this is a good idea. But that's a bit beyond this patch.
We could add an extra routine, and implement the two using
a parameter. And then slowly transition all the callers that
read this as an address to use the new one.
--
Joel
next prev parent reply other threads:[~2011-10-04 19:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 21:10 Joel Brobecker
2011-10-04 17:16 ` Tom Tromey
2011-10-04 19:32 ` Ulrich Weigand
2011-10-04 19:38 ` Joel Brobecker [this message]
2011-10-04 23:06 ` Ulrich Weigand
2011-10-05 1:09 ` Joel Brobecker
2011-10-05 12:30 ` Ulrich Weigand
2011-10-09 16:35 ` [patch#2] " Jan Kratochvil
2011-10-17 1:56 ` Joel Brobecker
2011-10-17 7:59 ` Tristan Gingold
2011-10-17 13:22 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004193739.GM19246@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox