From: Pedro Alves <pedro@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: combine bfd_lookup_symbol in solib-*.c
Date: Mon, 29 Aug 2011 16:33:00 -0000 [thread overview]
Message-ID: <201108291733.22228.pedro@codesourcery.com> (raw)
In-Reply-To: <4E5BBCD9.2060503@codesourcery.com>
Thanks.
On Monday 29 August 2011 17:22:49, Yao Qi wrote:
> +CORE_ADDR
> +gdb_bfd_lookup_symbol (bfd *abfd,
> + int (*match_sym) (asymbol *, const void *),
> + const void *data)
> +{
The patch is okay if you remove the "const"s. It's common to
want to increment a counter in `data' or something like that.
(Try `$ grep iterate_over_ *.h' to see other examples of the pattern).
--
Pedro Alves
next prev parent reply other threads:[~2011-08-29 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 15:37 Yao Qi
2011-08-28 14:41 ` [ping] " Yao Qi
2011-08-29 11:41 ` Pedro Alves
2011-08-29 16:23 ` Yao Qi
2011-08-29 16:33 ` Pedro Alves [this message]
2011-08-30 2:51 ` [committed]: " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108291733.22228.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox