From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24106 invoked by alias); 29 Aug 2011 16:33:41 -0000 Received: (qmail 24095 invoked by uid 22791); 29 Aug 2011 16:33:40 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Aug 2011 16:33:25 +0000 Received: (qmail 20738 invoked from network); 29 Aug 2011 16:33:24 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Aug 2011 16:33:24 -0000 From: Pedro Alves To: Yao Qi Subject: Re: combine bfd_lookup_symbol in solib-*.c Date: Mon, 29 Aug 2011 16:33:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.0; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <4E4D318E.704@codesourcery.com> <201108291241.02099.pedro@codesourcery.com> <4E5BBCD9.2060503@codesourcery.com> In-Reply-To: <4E5BBCD9.2060503@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201108291733.22228.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00572.txt.bz2 Thanks. On Monday 29 August 2011 17:22:49, Yao Qi wrote: > +CORE_ADDR > +gdb_bfd_lookup_symbol (bfd *abfd, > + int (*match_sym) (asymbol *, const void *), > + const void *data) > +{ The patch is okay if you remove the "const"s. It's common to want to increment a counter in `data' or something like that. (Try `$ grep iterate_over_ *.h' to see other examples of the pattern). -- Pedro Alves