From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 3/2] Do not bpstat_clear_actions on throw_exception - async fixes
Date: Fri, 26 Aug 2011 21:07:00 -0000 [thread overview]
Message-ID: <20110826210705.GB15507@host1.jankratochvil.net> (raw)
In-Reply-To: <201108241133.46693.pedro@codesourcery.com>
On Wed, 24 Aug 2011 12:33:46 +0200, Pedro Alves wrote:
> Hmm, I don't understand the "drop the bpstat_clear_actions call"
> part? Isn't that undoing your last change to the previous patch?
I agree, it was bogus.
> > + exception_print (gdb_stderr, e);
>
> ... this one though. Isn't this bit the only thing missing, and
> the rest would be considered just a cleanup? What am I missing?
Yes.
It looks like pre-approved, I will check it in with the [patch 2/2].
(Without the gdb.base/commands.exp part.)
Thanks,
Jan
gdb/
2011-08-26 Jan Kratochvil <jan.kratochvil@redhat.com>
* inf-loop.c (inferior_event_handler): Add exception_print in
INF_EXEC_COMPLETE.
--- a/gdb/inf-loop.c
+++ b/gdb/inf-loop.c
@@ -121,6 +121,7 @@ inferior_event_handler (enum inferior_event_type event_type,
{
bpstat_do_actions ();
}
+ exception_print (gdb_stderr, e);
if (!was_sync
&& exec_done_display_p
--- a/gdb/testsuite/gdb.base/commands.exp
+++ b/gdb/testsuite/gdb.base/commands.exp
@@ -740,6 +740,7 @@ proc error_clears_commands_left {} {
}
gdb_test_no_output "end" "main commands 2c"
+ gdb_test_no_output "set target-async on"
gdb_run_cmd
gdb_test "" "\r\nhook-stop1\r\n.*\r\ncmd1\r\nUndefined command: \"errorcommandxy\"\\. Try \"help\"\\." "cmd1 error"
next prev parent reply other threads:[~2011-08-26 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110823203520.GB4325@host1.jankratochvil.net>
2011-08-24 10:34 ` Pedro Alves
2011-08-26 21:07 ` Jan Kratochvil [this message]
2011-08-26 21:38 ` Pedro Alves
2011-08-26 21:48 ` Jan Kratochvil
2011-08-23 20:36 Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826210705.GB15507@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox