From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12018 invoked by alias); 26 Aug 2011 21:07:28 -0000 Received: (qmail 12008 invoked by uid 22791); 26 Aug 2011 21:07:27 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 21:07:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7QL78wZ000443 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Aug 2011 17:07:08 -0400 Received: from host1.jankratochvil.net (ovpn-116-38.ams2.redhat.com [10.36.116.38]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7QL76KB018090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Aug 2011 17:07:08 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7QL768r015977; Fri, 26 Aug 2011 23:07:06 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7QL76fE015976; Fri, 26 Aug 2011 23:07:06 +0200 Date: Fri, 26 Aug 2011 21:07:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/2] Do not bpstat_clear_actions on throw_exception - async fixes Message-ID: <20110826210705.GB15507@host1.jankratochvil.net> References: <20110823203520.GB4325@host1.jankratochvil.net> <201108241133.46693.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201108241133.46693.pedro@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00515.txt.bz2 On Wed, 24 Aug 2011 12:33:46 +0200, Pedro Alves wrote: > Hmm, I don't understand the "drop the bpstat_clear_actions call" > part? Isn't that undoing your last change to the previous patch? I agree, it was bogus. > > + exception_print (gdb_stderr, e); > > ... this one though. Isn't this bit the only thing missing, and > the rest would be considered just a cleanup? What am I missing? Yes. It looks like pre-approved, I will check it in with the [patch 2/2]. (Without the gdb.base/commands.exp part.) Thanks, Jan gdb/ 2011-08-26 Jan Kratochvil * inf-loop.c (inferior_event_handler): Add exception_print in INF_EXEC_COMPLETE. --- a/gdb/inf-loop.c +++ b/gdb/inf-loop.c @@ -121,6 +121,7 @@ inferior_event_handler (enum inferior_event_type event_type, { bpstat_do_actions (); } + exception_print (gdb_stderr, e); if (!was_sync && exec_done_display_p --- a/gdb/testsuite/gdb.base/commands.exp +++ b/gdb/testsuite/gdb.base/commands.exp @@ -740,6 +740,7 @@ proc error_clears_commands_left {} { } gdb_test_no_output "end" "main commands 2c" + gdb_test_no_output "set target-async on" gdb_run_cmd gdb_test "" "\r\nhook-stop1\r\n.*\r\ncmd1\r\nUndefined command: \"errorcommandxy\"\\. Try \"help\"\\." "cmd1 error"