Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix target-async SIGTTOU stop (PR 12260)
Date: Tue, 23 Aug 2011 19:32:00 -0000	[thread overview]
Message-ID: <20110823193156.GA30724@host1.jankratochvil.net> (raw)

Hi,

it is difficult to play with `set target-async on' as it usually SIGTTOU stops
at various places.
http://sourceware.org/bugzilla/show_bug.cgi?id=12260

$ ./gdb -nx -ex 'set target-async on' -ex start ./gdb
[...]
Starting program: .../gdb/gdb 
[1]+  Stopped                 ./gdb -nx -ex 'set target-async on' -ex start ./gdb

If it has a regression it IMO only means there is missing
target_terminal_inferior call at some other place.

No regressions on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu.  But I was
unable to reproduce the problem under DejaGnu so the regression test may not
be meaningful.

Not going to check it in without a review.


Thanks,
Jan


gdb/
2011-08-23  Jan Kratochvil  <jan.kratochvil@redhat.com>

	PR 12260
	* event-top.c (cli_command_loop): Call target_terminal_ours.

--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -193,6 +193,8 @@ cli_command_loop (void)
       char *a_prompt;
       char *gdb_prompt = get_prompt (0);
 
+      target_terminal_ours ();
+
       /* Tell readline what the prompt to display is and what function
          it will need to call after a whole line is read.  This also
          displays the first prompt.  */


             reply	other threads:[~2011-08-23 19:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23 19:32 Jan Kratochvil [this message]
2011-08-24  5:24 ` Matt Rice
2011-08-29 15:17   ` Pedro Alves
2011-08-29 15:26     ` Matt Rice
2011-09-23 16:33 ` cancel/resolved: " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110823193156.GA30724@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox