From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, lgustavo@codesourcery.com
Subject: Re: [PATCH] Move common linux procfs code to common/
Date: Tue, 23 Aug 2011 17:58:00 -0000 [thread overview]
Message-ID: <201108231858.31512.pedro@codesourcery.com> (raw)
In-Reply-To: <4E53B052.8030006@codesourcery.com>
On Tuesday 23 August 2011 14:51:14, Luis Machado wrote:
> Hi,
>
> This patch moves the linux procfs-related function "linux_proc_get_tgid"
> to the common subdirectory so GDBServer can use it as well, avoiding
> duplicated code.
>
> This is a preparation for the next GDBServer patch i will submit shortly.
>
> If there are no objections, i will check it in at the end of the day.
Saying "pre-approved by Foo offlist" is more usual in such cases.
FAOD, this is okay.
On Tuesday 23 August 2011 14:51:14, Luis Machado wrote:
> -linux-low.o: linux-low.c $(linux_low_h) $(linux_ptrace_h) $(server_h) $(linux_osdata_h)
> +linux-low.o: linux-low.c $(linux_low_h) $(linux_ptrace_h) $(linux_procfs_h) \
> + $(server_h) $(linux_osdata_h)
> $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< @USE_THREAD_DB@
Ah, this should be part of the other patch, not this one. linux-low.c was
not changed in this patch. Please move this hunk to the other patch
before committing.
--
Pedro Alves
next prev parent reply other threads:[~2011-08-23 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 13:51 Luis Machado
2011-08-23 17:58 ` Pedro Alves [this message]
2011-08-24 12:23 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108231858.31512.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox