From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7930 invoked by alias); 23 Aug 2011 17:58:48 -0000 Received: (qmail 7917 invoked by uid 22791); 23 Aug 2011 17:58:47 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_OC X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 17:58:34 +0000 Received: (qmail 6011 invoked from network); 23 Aug 2011 17:58:33 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Aug 2011 17:58:33 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, lgustavo@codesourcery.com Subject: Re: [PATCH] Move common linux procfs code to common/ Date: Tue, 23 Aug 2011 17:58:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.0; x86_64; ; ) References: <4E53B052.8030006@codesourcery.com> In-Reply-To: <4E53B052.8030006@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201108231858.31512.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00421.txt.bz2 On Tuesday 23 August 2011 14:51:14, Luis Machado wrote: > Hi, > > This patch moves the linux procfs-related function "linux_proc_get_tgid" > to the common subdirectory so GDBServer can use it as well, avoiding > duplicated code. > > This is a preparation for the next GDBServer patch i will submit shortly. > > If there are no objections, i will check it in at the end of the day. Saying "pre-approved by Foo offlist" is more usual in such cases. FAOD, this is okay. On Tuesday 23 August 2011 14:51:14, Luis Machado wrote: > -linux-low.o: linux-low.c $(linux_low_h) $(linux_ptrace_h) $(server_h) $(linux_osdata_h) > +linux-low.o: linux-low.c $(linux_low_h) $(linux_ptrace_h) $(linux_procfs_h) \ > + $(server_h) $(linux_osdata_h) > $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< @USE_THREAD_DB@ Ah, this should be part of the other patch, not this one. linux-low.c was not changed in this patch. Please move this hunk to the other patch before committing. -- Pedro Alves