From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
Sergio Durigan Junior <sergiodj@redhat.com>
Subject: Re: [RFC] Make solib_add regex-free
Date: Tue, 09 Aug 2011 11:10:00 -0000 [thread overview]
Message-ID: <201108091210.37873.pedro@codesourcery.com> (raw)
In-Reply-To: <20110809095838.GA32172@host1.jankratochvil.net>
On Tuesday 09 August 2011 10:58:38, Jan Kratochvil wrote:
> > +/* GLOBAL FUNCTION
> > +
> > + solib_add -- read in symbol info for newly added shared libraries
> > +
> > + SYNOPSIS
> > +
> > + void solib_add (VEC(so_list_p) *so_list, int from_tty,
> > + struct target_ops *target, int readsyms)
> > +
> > + DESCRIPTION
> > +
>
> While it was in the GDB code the new code no longer uses so large+duplicate
> headers, this part could be better dropped in new code I think.
Agreed. This came up just recently in the tic6x patches review too.
I think we should rework all such comments in the current codebase
to follow the standard, to avoid proliferation. There aren't that
many. I will do this.
--
Pedro Alves
next prev parent reply other threads:[~2011-08-09 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 0:53 Sergio Durigan Junior
2011-08-09 9:59 ` Jan Kratochvil
2011-08-09 11:10 ` Pedro Alves [this message]
2011-08-09 18:10 ` Sergio Durigan Junior
2011-08-09 20:41 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108091210.37873.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox