From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82915-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15084 invoked by alias); 9 Aug 2011 11:10:58 -0000
Received: (qmail 15075 invoked by uid 22791); 9 Aug 2011 11:10:57 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Aug 2011 11:10:42 +0000
Received: (qmail 13793 invoked from network); 9 Aug 2011 11:10:40 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 9 Aug 2011 11:10:40 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] Make solib_add regex-free
Date: Tue, 09 Aug 2011 11:10:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-10-generic; KDE/4.7.0; x86_64; ; )
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, Sergio Durigan Junior <sergiodj@redhat.com>
References: <m3ty9r9zin.fsf@redhat.com> <20110809095838.GA32172@host1.jankratochvil.net>
In-Reply-To: <20110809095838.GA32172@host1.jankratochvil.net>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201108091210.37873.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00175.txt.bz2

On Tuesday 09 August 2011 10:58:38, Jan Kratochvil wrote:
> > +/* GLOBAL FUNCTION
> > +
> > +   solib_add -- read in symbol info for newly added shared libraries
> > +
> > +   SYNOPSIS
> > +
> > +   void solib_add (VEC(so_list_p) *so_list, int from_tty,
> > +                struct target_ops *target, int readsyms)
> > +
> > +   DESCRIPTION
> > +
> 
> While it was in the GDB code the new code no longer uses so large+duplicate
> headers, this part could be better dropped in new code I think.

Agreed.  This came up just recently in the tic6x patches review too.
I think we should rework all such comments in the current codebase
to follow the standard, to avoid proliferation.  There aren't that
many.  I will do this.

-- 
Pedro Alves