[PATCH] fix config.rpath for cygwin/mingw

[PATCH] fix config.rpath for cygwin/mingw

[Yaakov (Cygwin/X)]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

The gettext macros use config.rpath to determine the link library name
of libiconv and libintl (on non-glibc platforms); the import library
suffix is of importance, not the runtime library suffix.  On PE
platforms, these differ, and by using the latter in config.rpath, the
gettext macros think shared import libraries aren't available, and
forces linking with the static library instead.

(FWIW, gettext itself has already been fixed in this regard, but
updating to the latest version of those files is much more invasive.)

The attached patch fixes linking with the shared import libraries.  We
have been using this patch for over a year on i686-pc-cygwin hosted
toolchains (both native- and cross-target).


Yaakov
Cygwin Ports



[-- Attachment #2: config-rpath.patch --]
[-- Type: text/x-patch, Size: 479 bytes --]

2011-07-20  Yaakov Selkowitz  <yselkowitz@users.sourceforge.net>

	* config.rpath [cygwin|mingw*|pw32] (shrext): Change to .dll.a,
	to match the import library suffix.

Index: config.rpath
===================================================================
--- config.rpath	(revision 176494)
+++ config.rpath	(working copy)
@@ -438,7 +438,7 @@
   bsdi4*)
     ;;
   cygwin* | mingw* | pw32*)
-    shrext=.dll
+    shrext=.dll.a
     ;;
   darwin* | rhapsody*)
     shrext=.dylib

Re: [PATCH] fix config.rpath for cygwin/mingw

[Christopher Faylor]

On Wed, Jul 20, 2011 at 02:04:06AM -0500, Yaakov (Cygwin/X) wrote:
>The gettext macros use config.rpath to determine the link library name
>of libiconv and libintl (on non-glibc platforms); the import library
>suffix is of importance, not the runtime library suffix.  On PE
>platforms, these differ, and by using the latter in config.rpath, the
>gettext macros think shared import libraries aren't available, and
>forces linking with the static library instead.
>
>(FWIW, gettext itself has already been fixed in this regard, but
>updating to the latest version of those files is much more invasive.)
>
>The attached patch fixes linking with the shared import libraries.  We
>have been using this patch for over a year on i686-pc-cygwin hosted
>toolchains (both native- and cross-target).
>
>
>Yaakov
>Cygwin Ports
>
>

>2011-07-20  Yaakov Selkowitz  <yselkowitz@users.sourceforge.net>
>
>	* config.rpath [cygwin|mingw*|pw32] (shrext): Change to .dll.a,
>	to match the import library suffix.

Looks ok.  Do you have a CVS tree checked out which would enable you to
check this in?  You probably have privileges since gdb overlaps with Cygwin.

cgf

Re: [PATCH] fix config.rpath for cygwin/mingw

[Yaakov (Cygwin/X)]

On Wed, Jul 20, 2011 at 14:25, Christopher Faylor wrote:
> On Wed, Jul 20, 2011 at 02:04:06AM -0500, Yaakov (Cygwin/X) wrote:
>>2011-07-20  Yaakov Selkowitz  <yselkowitz@...>
>>
>>       * config.rpath [cygwin|mingw*|pw32] (shrext): Change to .dll.a,
>>       to match the import library suffix.
>
> Looks ok.  Do you have a CVS tree checked out which would enable you to
> check this in?

I do.  But I have sent the same patch to gcc-patches@ and binutils@;
since this affects all of them, do I need to wait for approval there
as well?


Yaakov
Cygwin Ports

Re: [PATCH] fix config.rpath for cygwin/mingw

[Christopher Faylor]

On Wed, Jul 20, 2011 at 03:45:59PM -0500, Yaakov (Cygwin/X) wrote:
>On Wed, Jul 20, 2011 at 14:25, Christopher Faylor wrote:
>> On Wed, Jul 20, 2011 at 02:04:06AM -0500, Yaakov (Cygwin/X) wrote:
>>>2011-07-20 ?Yaakov Selkowitz ?<yselkowitz@...>
>>>
>>> ? ? ? * config.rpath [cygwin|mingw*|pw32] (shrext): Change to .dll.a,
>>> ? ? ? to match the import library suffix.
>>
>> Looks ok. ?Do you have a CVS tree checked out which would enable you to
>> check this in?
>
>I do.  But I have sent the same patch to gcc-patches@ and binutils@;
>since this affects all of them, do I need to wait for approval there
>as well?

Urgh.  Actually, I somehow missed that this was a top-level configury
component.  I can't approve those.  I'm never clear on how the files are
supposed to be kept in sync.  binutils and gdb are the same file so
you'd only have to check in once but gcc is entirely separate.

So, sorry.  You'll have to wait for approval by someone who handles the
top-level configury.

cgf