From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Code cleanup: Introduce allocate_optimized_out_value
Date: Tue, 12 Jul 2011 21:37:00 -0000 [thread overview]
Message-ID: <20110712211703.GA4277@host1.jankratochvil.net> (raw)
In-Reply-To: <m38vs3fbo5.fsf@fleche.redhat.com>
On Tue, 12 Jul 2011 23:10:02 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> this is a code cleanup. Additionally it makes more optimized_out values lazy.
> Jan> IIRC I had some compatibility problems before with it but I no longer see any
> Jan> regressions, maybe since:
> Jan> [patch 1/2] Make values more lazy if possible
> Jan> http://sourceware.org/ml/gdb-patches/2011-01/msg00123.html
> Jan> or thanks to some other patch.
>
> It looks ok to me.
It is true it would be definitely a bug in a code incompatible with such
change so one may rather fix that possible regression there.
Checked it in:
http://sourceware.org/ml/gdb-cvs/2011-07/msg00124.html
Thanks for the review,
Jan
prev parent reply other threads:[~2011-07-12 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 21:09 Jan Kratochvil
2011-07-12 21:17 ` Tom Tromey
2011-07-12 21:37 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712211703.GA4277@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox