From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17910 invoked by alias); 12 Jul 2011 21:17:20 -0000 Received: (qmail 17902 invoked by uid 22791); 12 Jul 2011 21:17:20 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jul 2011 21:17:06 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6CLH6L1000778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 12 Jul 2011 17:17:06 -0400 Received: from host1.jankratochvil.net ([10.3.113.13]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6CLH4Tw015788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 12 Jul 2011 17:17:05 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p6CLH31k006235; Tue, 12 Jul 2011 23:17:03 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p6CLH3Xp006234; Tue, 12 Jul 2011 23:17:03 +0200 Date: Tue, 12 Jul 2011 21:37:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch] Code cleanup: Introduce allocate_optimized_out_value Message-ID: <20110712211703.GA4277@host1.jankratochvil.net> References: <20110712204311.GA324@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00329.txt.bz2 On Tue, 12 Jul 2011 23:10:02 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> this is a code cleanup. Additionally it makes more optimized_out values lazy. > Jan> IIRC I had some compatibility problems before with it but I no longer see any > Jan> regressions, maybe since: > Jan> [patch 1/2] Make values more lazy if possible > Jan> http://sourceware.org/ml/gdb-patches/2011-01/msg00123.html > Jan> or thanks to some other patch. > > It looks ok to me. It is true it would be definitely a bug in a code incompatible with such change so one may rather fix that possible regression there. Checked it in: http://sourceware.org/ml/gdb-cvs/2011-07/msg00124.html Thanks for the review, Jan