From: Joel Brobecker <brobecker@adacore.com>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: gdb-patches@sourceware.org, ac131313@redhat.com
Subject: Re: Committed: removing all #if 0'd code in sim/igen.
Date: Fri, 08 Jul 2011 06:30:00 -0000 [thread overview]
Message-ID: <20110708042643.GL2407@adacore.com> (raw)
In-Reply-To: <201107080227.p682RhI6022663@ignucius.se.axis.com>
> I choose to be a bit verbose in the ChangeLog, to appease
> whoever might think that keeping #if 0'd code around is a great
> idea for stashing work-in-progress.
FWIW, I'm also on the radical side. If the code is ifdef'ed out,
and has been for more than a short amount of time, then I consider
removing it an obvious change. It's easy to dig back out if anyone
wants to work on it, and in the meantime, they don't cause extra
maintainance just trying to maintain dead code.
--
Joel
prev parent reply other threads:[~2011-07-08 4:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 3:45 Hans-Peter Nilsson
2011-07-08 6:30 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708042643.GL2407@adacore.com \
--to=brobecker@adacore.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hans-peter.nilsson@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox