From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8528 invoked by alias); 8 Jul 2011 04:27:04 -0000 Received: (qmail 8456 invoked by uid 22791); 8 Jul 2011 04:27:02 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jul 2011 04:26:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E29602BACFF; Fri, 8 Jul 2011 00:26:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id edRM-eLdPQlu; Fri, 8 Jul 2011 00:26:45 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9B27F2BACEE; Fri, 8 Jul 2011 00:26:45 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 662BA145615; Thu, 7 Jul 2011 21:26:43 -0700 (PDT) Date: Fri, 08 Jul 2011 06:30:00 -0000 From: Joel Brobecker To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org, ac131313@redhat.com Subject: Re: Committed: removing all #if 0'd code in sim/igen. Message-ID: <20110708042643.GL2407@adacore.com> References: <201107080227.p682RhI6022663@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201107080227.p682RhI6022663@ignucius.se.axis.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00254.txt.bz2 > I choose to be a bit verbose in the ChangeLog, to appease > whoever might think that keeping #if 0'd code around is a great > idea for stashing work-in-progress. FWIW, I'm also on the radical side. If the code is ifdef'ed out, and has been for more than a short amount of time, then I consider removing it an obvious change. It's easy to dig back out if anyone wants to work on it, and in the meantime, they don't cause extra maintainance just trying to maintain dead code. -- Joel