From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [Darwin 2/4] Do not crash (failed assertion) after PT_KILL ptrace error
Date: Sun, 03 Jul 2011 16:18:00 -0000 [thread overview]
Message-ID: <20110703045547.GL2407@adacore.com> (raw)
In-Reply-To: <201107021658.p62GwoWV017449@glazunov.sibelius.xs4all.nl>
> I think I disagree here. PT_KILL should only fail if you pass it the
> wrong process ID. So unless there is an OS bug of some sorts, this is
> going to be a GDB internal error. Do you have actual evidence there
> is a kernel bug here?
It's true I don't. And I agree that the error could be an internal error,
but it could just as well be an error in the kernel too. So I still think
that an internal error/assert is too strong. What's more, we can still
continue without any degradation in the debugger performance. We just
failed one action which isn't critical to GDB's internal state.
--
Joel
WARNING: multiple messages have this Message-ID
From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [Darwin 2/4] Do not crash (failed assertion) after PT_KILL ptrace error
Date: Sun, 03 Jul 2011 07:30:00 -0000 [thread overview]
Message-ID: <20110703045547.GL2407@adacore.com> (raw)
Message-ID: <20110703073000.BQNs95PFmWr48ucslxrWoAYLq0XBx8z6FgIrGa_Hv8o@z> (raw)
In-Reply-To: <201107021658.p62GwoWV017449@glazunov.sibelius.xs4all.nl>
> I think I disagree here. PT_KILL should only fail if you pass it the
> wrong process ID. So unless there is an OS bug of some sorts, this is
> going to be a GDB internal error. Do you have actual evidence there
> is a kernel bug here?
It's true I don't. And I agree that the error could be an internal error,
but it could just as well be an error in the kernel too. So I still think
that an internal error/assert is too strong. What's more, we can still
continue without any degradation in the debugger performance. We just
failed one action which isn't critical to GDB's internal state.
--
Joel
next prev parent reply other threads:[~2011-07-03 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 19:03 Various fixes to the Darwin port Joel Brobecker
2011-07-01 19:03 ` [Darwin 3/4] [mach-o] get rid of current_oso global Joel Brobecker
2011-07-01 19:03 ` [Darwin 1/4] detach: Do not resume inferior after ptrace detach Joel Brobecker
2011-07-01 19:03 ` [Darwin 2/4] Do not crash (failed assertion) after PT_KILL ptrace error Joel Brobecker
2011-07-02 16:59 ` Mark Kettenis
2011-07-03 16:18 ` Joel Brobecker [this message]
2011-07-03 7:30 ` Joel Brobecker
2011-07-01 19:11 ` [Darwin 4/4] remove comment in machoread.c (macho_symfile_read) Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110703045547.GL2407@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox