From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: yao@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch, testsuite] gdb.base/savedregs.exp: SIGSEGV -> SIGILL
Date: Thu, 09 Jun 2011 11:19:00 -0000 [thread overview]
Message-ID: <201106091117.p59BHRWi025356@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <4DF09229.4070704@codesourcery.com> (message from Yao Qi on Thu, 09 Jun 2011 17:28:09 +0800)
> Date: Thu, 09 Jun 2011 17:28:09 +0800
> From: Yao Qi <yao@codesourcery.com>
>
> In current gdb.base/savedregs.exp, signal handler is installed for
> signal SIGSEGV, and SIGSEGV is trigger by `*(char *)0 = 0;'. However,
> on non-mmu uclinux system, writing to an address 0x0 doesn't trigger
> SIGSEGV.
>
> In my patch, SIGILL is chosen to replace SIGSEGV. One assumption here
> is that 0xffff is an invalid instruction on all ports.
Please don't do this. You're changing the test significantly. And
there is no guarantee that 0xffff is an invalid instruction. Heck
most platforms don't even have 16-bit instructions.
next prev parent reply other threads:[~2011-06-09 11:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 9:28 Yao Qi
2011-06-09 10:08 ` Andreas Schwab
2011-06-09 10:53 ` Yao Qi
2011-06-09 11:19 ` Mark Kettenis [this message]
2011-06-09 11:41 ` Pedro Alves
2011-06-09 13:25 ` Yao Qi
2011-06-09 13:10 ` Yao Qi
2011-06-09 14:25 ` Pedro Alves
2011-06-20 4:13 ` [patch V2, testsuite] gdb.base/savedregs.exp: SIGSEGV -> SIGALRM Yao Qi
2011-06-20 7:03 ` Mark Kettenis
2011-06-20 8:26 ` Yao Qi
2011-06-20 11:12 ` Mark Kettenis
2011-06-20 15:07 ` Yao Qi
2011-06-20 15:14 ` Paul Koning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106091117.p59BHRWi025356@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox