From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/DWARF] address size can be different from DW_OP_deref size
Date: Fri, 03 Jun 2011 17:47:00 -0000 [thread overview]
Message-ID: <20110603174710.GC2661@adacore.com> (raw)
In-Reply-To: <m3mxhyj2wm.fsf@fleche.redhat.com>
> >>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>
> Joel> * dwarf2expr.c (execute_stack_op) [DW_OP_deref]: Handle
> Joel> the case where ADDR_SIZE is different from TYPE_LENGTH (type).
>
> This looks correct to me. I also looked at the typed DWARF extension
> and I believe this code is appropriate for that as well.
Thanks for the review. I've now checked the patch in.
> I think it is suitable for 7.3 as well, FWIW.
It looks fine on the branch, though. Were you planning on checking in
the typed-dwarf series on the branch as well?
--
Joel
next prev parent reply other threads:[~2011-06-03 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 14:46 Joel Brobecker
2011-06-03 16:28 ` Tom Tromey
2011-06-03 17:47 ` Joel Brobecker [this message]
2011-06-03 18:54 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603174710.GC2661@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox