From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11171 invoked by alias); 3 Jun 2011 17:47:28 -0000 Received: (qmail 11163 invoked by uid 22791); 3 Jun 2011 17:47:28 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Jun 2011 17:47:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1B1962BB4F2; Fri, 3 Jun 2011 13:47:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3srX7HyLeyYJ; Fri, 3 Jun 2011 13:47:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E3EB82BB4F0; Fri, 3 Jun 2011 13:47:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8E721145615; Fri, 3 Jun 2011 10:47:10 -0700 (PDT) Date: Fri, 03 Jun 2011 17:47:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/DWARF] address size can be different from DW_OP_deref size Message-ID: <20110603174710.GC2661@adacore.com> References: <1307112377-17952-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00057.txt.bz2 > >>>>> "Joel" == Joel Brobecker writes: > > Joel> * dwarf2expr.c (execute_stack_op) [DW_OP_deref]: Handle > Joel> the case where ADDR_SIZE is different from TYPE_LENGTH (type). > > This looks correct to me. I also looked at the typed DWARF extension > and I believe this code is appropriate for that as well. Thanks for the review. I've now checked the patch in. > I think it is suitable for 7.3 as well, FWIW. It looks fine on the branch, though. Were you planning on checking in the typed-dwarf series on the branch as well? -- Joel