Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org, Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: regression: gdb.objc/basicclass.exp
Date: Thu, 02 Jun 2011 09:30:00 -0000	[thread overview]
Message-ID: <20110602092946.GA28687@host1.jankratochvil.net> (raw)
In-Reply-To: <4DE6BB98.5070901@redhat.com>

On Thu, 02 Jun 2011 00:22:16 +0200, Keith Seitz wrote:
> This is all way more verbiage than the simple patch to fix it:
> increment the counter before shorting the loop.

since:
commit 1a9561ecd22cbc983e3c981630bcb8565aa8e095
2009-05-13  Paul Pluzhnikov  <ppluzhnikov@google.com>
	* objc-lang.c (objc_objfile_data): New variable.
	(find_methods): Skip objfiles without Obj-C methods.
	(_initialize_objc_lang): New function.

I agree, please check it in.

The only file having objc methods on my box is
/usr/lib/debug/usr/lib64/libobjc.so.3.0.0.debug and parse_method does not fail
on any of its symbols so it does not even make the performance worse (on this
file).


Thanks,
Jan


  reply	other threads:[~2011-06-02  9:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 18:47 [RFA] "Error in re-setting breakpoint," c++/12750 Keith Seitz
2011-05-31 20:59 ` Tom Tromey
2011-05-31 22:16   ` Keith Seitz
2011-06-01  7:08     ` regression: gdb.objc/basicclass.exp [Re: [RFA] "Error in re-setting breakpoint," c++/12750] Jan Kratochvil
2011-06-01 19:55       ` Keith Seitz
2011-06-01 22:22       ` Keith Seitz
2011-06-02  9:30         ` Jan Kratochvil [this message]
2011-06-02 18:47           ` regression: gdb.objc/basicclass.exp Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110602092946.GA28687@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox