From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19517 invoked by alias); 2 Jun 2011 09:30:12 -0000 Received: (qmail 19499 invoked by uid 22791); 2 Jun 2011 09:30:11 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Jun 2011 09:29:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p529TpKV008065 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 Jun 2011 05:29:51 -0400 Received: from host1.jankratochvil.net (ovpn-113-38.phx2.redhat.com [10.3.113.38]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p529TnEQ013076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 2 Jun 2011 05:29:50 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p529Tm5p013412; Thu, 2 Jun 2011 11:29:48 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p529TlKA013401; Thu, 2 Jun 2011 11:29:47 +0200 Date: Thu, 02 Jun 2011 09:30:00 -0000 From: Jan Kratochvil To: Keith Seitz Cc: gdb-patches@sourceware.org, Paul Pluzhnikov Subject: Re: regression: gdb.objc/basicclass.exp Message-ID: <20110602092946.GA28687@host1.jankratochvil.net> References: <4DD6B72D.3060706@redhat.com> <4DE568A5.4000306@redhat.com> <20110601070737.GA29856@host1.jankratochvil.net> <4DE6BB98.5070901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DE6BB98.5070901@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00017.txt.bz2 On Thu, 02 Jun 2011 00:22:16 +0200, Keith Seitz wrote: > This is all way more verbiage than the simple patch to fix it: > increment the counter before shorting the loop. since: commit 1a9561ecd22cbc983e3c981630bcb8565aa8e095 2009-05-13 Paul Pluzhnikov * objc-lang.c (objc_objfile_data): New variable. (find_methods): Skip objfiles without Obj-C methods. (_initialize_objc_lang): New function. I agree, please check it in. The only file having objc methods on my box is /usr/lib/debug/usr/lib64/libobjc.so.3.0.0.debug and parse_method does not fail on any of its symbols so it does not even make the performance worse (on this file). Thanks, Jan