[commit/sim] Add `sim_complete_command' definition to erc32 sim

[commit/sim] Add `sim_complete_command' definition to erc32 sim

[Joel Brobecker]

This patch fixes a build failure at link time due to
sim_complete_command being undefined.  There was a recent change
that added this function to all the ports that do not use the
common/ subdir.  But somehow, the erc32 port got missed.

sim/erc32/ChangeLog:

        * interf.c (sim_complete_command): New stub function.

Checked in.

---
 sim/erc32/ChangeLog |    4 ++++
 sim/erc32/interf.c  |    6 ++++++
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/sim/erc32/ChangeLog b/sim/erc32/ChangeLog
index cf128ba..5317b99 100644
--- a/sim/erc32/ChangeLog
+++ b/sim/erc32/ChangeLog
@@ -1,3 +1,7 @@
+2011-06-01  Joel Brobecker  <brobecker@adacore.com>
+
+	* interf.c (sim_complete_command): New stub function.
+
 2011-01-11  Andrew Burgess  <aburgess@broadcom.com>
 
 	* interf.c (sim_store_register): Update return value to
diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c
index d81511a..7ee4dee 100644
--- a/sim/erc32/interf.c
+++ b/sim/erc32/interf.c
@@ -481,6 +481,12 @@ sim_do_command(sd, cmd)
     exec_cmd(&sregs, cmd);
 }
 
+char **
+sim_complete_command (SIM_DESC sd, char *text, char *word)
+{
+  return NULL;
+}
+
 #if 0 /* FIXME: These shouldn't exist.  */
 
 int
-- 
1.7.1

Re: [commit/sim] Add `sim_complete_command' definition to erc32 sim

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 625 bytes --]

On Wednesday, June 01, 2011 13:35:38 Joel Brobecker wrote:
> This patch fixes a build failure at link time due to
> sim_complete_command being undefined.  There was a recent change
> that added this function to all the ports that do not use the
> common/ subdir.  But somehow, the erc32 port got missed.

i didnt build test it because i couldnt figure out how to even configure for 
the target.  i still dont ;).

$ ./configure --target=erc32-elf
checking target system type... Invalid configuration `erc32-elf': machine 
`erc32' not recognized
configure: error: /bin/sh ../../config.sub erc32-elf failed
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [commit/sim] Add `sim_complete_command' definition to erc32 sim

[Joel Brobecker]

> i didnt build test it because i couldnt figure out how to even configure for 
> the target.  i still dont ;).
> 
> $ ./configure --target=erc32-elf
> checking target system type... Invalid configuration `erc32-elf': machine 
> `erc32' not recognized
> configure: error: /bin/sh ../../config.sub erc32-elf failed

I wish we could add erc32-elf. Right now, the target is sparc-elf.
I haven't done it because tools like config.sub don't support it yet.
We could work on that, if it made sense.

-- 
Joel

Re: [commit/sim] Add `sim_complete_command' definition to erc32 sim

[Ralf Corsepius]

On 06/01/2011 08:56 PM, Joel Brobecker wrote:
>> i didnt build test it because i couldnt figure out how to even configure for
>> the target.  i still dont ;).
>>
>> $ ./configure --target=erc32-elf
>> checking target system type... Invalid configuration `erc32-elf': machine
>> `erc32' not recognized
>> configure: error: /bin/sh ../../config.sub erc32-elf failed
>
> I wish we could add erc32-elf. Right now, the target is sparc-elf.
More precisely sparc-*-* ... RTEMS supports it.

> I haven't done it because tools like config.sub don't support it yet.
> We could work on that, if it made sense.

IMO, it doesn't, because the erc32 is a sparc variant.

Ralf

Re: [commit/sim] Add `sim_complete_command' definition to erc32 sim

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 1725 bytes --]

On Wednesday, June 01, 2011 14:56:48 Joel Brobecker wrote:
> > i didnt build test it because i couldnt figure out how to even configure
> > for the target.  i still dont ;).
> > 
> > $ ./configure --target=erc32-elf
> > checking target system type... Invalid configuration `erc32-elf': machine
> > `erc32' not recognized
> > configure: error: /bin/sh ../../config.sub erc32-elf failed
> 
> I wish we could add erc32-elf. Right now, the target is sparc-elf.
> I haven't done it because tools like config.sub don't support it yet.
> We could work on that, if it made sense.

thanks, sparc-elf got me much further.  but it looks like the readline logic 
in sim/erc32/configure is off because it link fails for me:
make[2]: Entering directory `/usr/local/src/gnu/sourceware/build/build-
erc32/sim/erc32'
gcc -DHAVE_CONFIG_H     -DPROFILE=1 -DWITH_PROFILE=-1          -
DDEFAULT_INLINE=0           -DSTAT -DFAST_UART -DIUREV0 -DMECREV0   -I. -
I../../../../sim/erc32 -I../common -I../../../../sim/erc32/../common -
I../../include -I../../../../sim/erc32/../../include -I../../bfd -
I../../../../sim/erc32/../../bfd -I../../opcodes -
I../../../../sim/erc32/../../opcodes  -g -O2 -o sis \
  sis.o exec.o erc32.o func.o help.o float.o  ../../bfd/libbfd.a 
../../opcodes/libopcodes.a  ../../libiberty/libiberty.a -lz -lnsl  
../../readline/libreadline.a  -lm
../../readline/libreadline.a(display.o): In function `cr':
/usr/local/src/gnu/sourceware/build/build-
erc32/readline/../../../readline/display.c:2486: undefined reference to 
`tputs'
......
collect2: ld returned 1 exit status
make[2]: *** [sis] Error 1

manually tweaking the erc32 makefile to also link in -lcurses lets it get past
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]