From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [commit] Re: New ARI warning Sat May 28 01:53:47 UTC 2011
Date: Mon, 30 May 2011 19:50:00 -0000 [thread overview]
Message-ID: <20110530195019.GE2620@adacore.com> (raw)
In-Reply-To: <20110530192841.GA11867@host1.jankratochvil.net>
> --- src/gdb/linux-nat.c 2011/05/27 16:55:38 1.206
> +++ src/gdb/linux-nat.c 2011/05/30 19:26:36 1.207
> @@ -2365,7 +2365,7 @@
> FILE *procfile;
> int retval = 0;
>
> - sprintf (buffer, "/proc/%ld/status", lwp);
> + xsnprintf (buffer, sizeof (buffer), "/proc/%ld/status", lwp);
Elegant (duh!). I'll update the ARI documentation to mention xsnprintf
as well - the xstrprintf suggestion really put me in target-lock mode,
and I failed to think beyond it...
--
Joel
next prev parent reply other threads:[~2011-05-30 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 1:54 GDB Administrator
2011-05-30 18:35 ` Jan Kratochvil
2011-05-30 18:59 ` Joel Brobecker
2011-05-30 19:29 ` [commit] " Jan Kratochvil
2011-05-30 19:38 ` Mark Kettenis
2011-05-30 19:50 ` Joel Brobecker [this message]
2011-05-30 19:59 ` [ARI/commit] enhance suggestion in "sprintf" rule (was: "Re: [commit] Re: New ARI warning Sat May 28 01:53:47 UTC 2011") Joel Brobecker
2011-05-31 7:58 ` Pierre Muller
2011-05-30 19:16 ` New ARI warning Sat May 28 01:53:47 UTC 2011 Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530195019.GE2620@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox