From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Joel Brobecker'" <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: RE: [ARI/commit] enhance suggestion in "sprintf" rule (was: "Re: [commit] Re: New ARI warning Sat May 28 01:53:47 UTC 2011")
Date: Tue, 31 May 2011 07:58:00 -0000 [thread overview]
Message-ID: <005301cc1f68$758bae50$60a30af0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20110530195910.GF2620@adacore.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : lundi 30 mai 2011 21:59
> À : gdb-patches@sourceware.org
> Objet : [ARI/commit] enhance suggestion in "sprintf" rule (was: "Re:
> [commit] Re: New ARI warning Sat May 28 01:53:47 UTC 2011")
>
> > [...] I'll update the ARI documentation to mention xsnprintf
> > as well - the xstrprintf suggestion really put me in target-lock mode,
> > and I failed to think beyond it...
>
> This is what I checked in. Incidently, I noticed a typo, which
> I also fixed (this is the second patch).
Thanks for this ARI enhancement,
I did notice once that static buffers should use
xsnprintf function instead of xstrprintf that allocate a
buffer using global memory, but forgot to change ARI doc
for this rule...
I hope this will facilitate reduction of the number of
occurrences of this warning:
Currently, "Don't use sprintf" rule is found
184 times ...
So please don't hesitate to fix those issues
under the OBVIOUS rule!
Pierre Muller
as ARI maintainer
next prev parent reply other threads:[~2011-05-31 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 1:54 New ARI warning Sat May 28 01:53:47 UTC 2011 GDB Administrator
2011-05-30 18:35 ` Jan Kratochvil
2011-05-30 18:59 ` Joel Brobecker
2011-05-30 19:29 ` [commit] " Jan Kratochvil
2011-05-30 19:38 ` Mark Kettenis
2011-05-30 19:50 ` Joel Brobecker
2011-05-30 19:59 ` [ARI/commit] enhance suggestion in "sprintf" rule (was: "Re: [commit] Re: New ARI warning Sat May 28 01:53:47 UTC 2011") Joel Brobecker
2011-05-31 7:58 ` Pierre Muller [this message]
2011-05-30 19:16 ` New ARI warning Sat May 28 01:53:47 UTC 2011 Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005301cc1f68$758bae50$60a30af0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox