Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: don't forward declare gdb_thread and inferior in defs.h  (Re: simplify continuations a bit more.)
Date: Fri, 27 May 2011 18:44:00 -0000	[thread overview]
Message-ID: <201105271944.16687.pedro@codesourcery.com> (raw)
In-Reply-To: <201105271927.51070.pedro@codesourcery.com>

On Friday 27 May 2011 19:27:50, Pedro Alves wrote:
> (can't remove the struct thread_info and struct inferior
> forward declarations from defs.h without more changes)

Looked worse than it really is on first look.  Not much is relying
on those since they were put there in 2008.

Built an --enable-targets=all gdb on x86_64-linux successfully and applied.

-- 
Pedro Alves

2011-05-27  Pedro Alves  <pedro@codesourcery.com>

	gdb/
	* defs.h (struct thread_info, struct inferior): Delete forward
	declarations.
	* breakpoint.h (struct thread_info): New forward declaration.
	* observer.sh (struct inferior): New forward declaration.
	* python/python-internal.h (struct inferior): New forward
	declaration.

---
 gdb/breakpoint.h             |    1 +
 gdb/defs.h                   |    3 ---
 gdb/observer.sh              |    1 +
 gdb/python/python-internal.h |    1 +
 4 files changed, 3 insertions(+), 3 deletions(-)

Index: src/gdb/defs.h
===================================================================
--- src.orig/gdb/defs.h	2011-05-27 19:25:28.000000000 +0100
+++ src/gdb/defs.h	2011-05-27 19:29:26.760790228 +0100
@@ -730,9 +730,6 @@ extern struct command_line *read_command
 
 extern void free_command_lines (struct command_line **);
 
-struct thread_info;
-struct inferior;
-
 /* String containing the current directory (what getwd would return).  */
 
 extern char *current_directory;
Index: src/gdb/breakpoint.h
===================================================================
--- src.orig/gdb/breakpoint.h	2011-05-27 19:24:06.000000000 +0100
+++ src/gdb/breakpoint.h	2011-05-27 19:30:17.120790237 +0100
@@ -29,6 +29,7 @@ struct value;
 struct block;
 struct breakpoint_object;
 struct get_number_or_range_state;
+struct thread_info;
 
 /* This is the maximum number of bytes a breakpoint instruction can
    take.  Feel free to increase it.  It's just used in a few places to
Index: src/gdb/observer.sh
===================================================================
--- src.orig/gdb/observer.sh	2011-01-13 15:07:31.000000000 +0000
+++ src/gdb/observer.sh	2011-05-27 19:31:25.280790248 +0100
@@ -64,6 +64,7 @@ struct bpstats;
 struct so_list;
 struct objfile;
 struct thread_info;
+struct inferior;
 EOF
         ;;
 esac
Index: src/gdb/python/python-internal.h
===================================================================
--- src.orig/gdb/python/python-internal.h	2011-03-01 16:00:18.000000000 +0000
+++ src/gdb/python/python-internal.h	2011-05-27 19:35:28.510790291 +0100
@@ -106,6 +106,7 @@ struct value;
 struct language_defn;
 struct program_space;
 struct bpstats;
+struct inferior;
 
 extern PyObject *gdb_module;
 extern PyTypeObject value_object_type;


      parent reply	other threads:[~2011-05-27 18:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27 14:58 simplify continuations a bit more Pedro Alves
2011-05-27 17:59 ` Tom Tromey
2011-05-27 18:28   ` Pedro Alves
2011-05-27 18:32     ` Tom Tromey
2011-05-27 18:44     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105271944.16687.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox