From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4110 invoked by alias); 27 May 2011 18:44:38 -0000 Received: (qmail 4101 invoked by uid 22791); 27 May 2011 18:44:37 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_TW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 18:44:20 +0000 Received: (qmail 32754 invoked from network); 27 May 2011 18:44:19 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 May 2011 18:44:19 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: don't forward declare gdb_thread and inferior in defs.h (Re: simplify continuations a bit more.) Date: Fri, 27 May 2011 18:44:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: Tom Tromey References: <201105271557.33330.pedro@codesourcery.com> <201105271927.51070.pedro@codesourcery.com> In-Reply-To: <201105271927.51070.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105271944.16687.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00654.txt.bz2 On Friday 27 May 2011 19:27:50, Pedro Alves wrote: > (can't remove the struct thread_info and struct inferior > forward declarations from defs.h without more changes) Looked worse than it really is on first look. Not much is relying on those since they were put there in 2008. Built an --enable-targets=all gdb on x86_64-linux successfully and applied. -- Pedro Alves 2011-05-27 Pedro Alves gdb/ * defs.h (struct thread_info, struct inferior): Delete forward declarations. * breakpoint.h (struct thread_info): New forward declaration. * observer.sh (struct inferior): New forward declaration. * python/python-internal.h (struct inferior): New forward declaration. --- gdb/breakpoint.h | 1 + gdb/defs.h | 3 --- gdb/observer.sh | 1 + gdb/python/python-internal.h | 1 + 4 files changed, 3 insertions(+), 3 deletions(-) Index: src/gdb/defs.h =================================================================== --- src.orig/gdb/defs.h 2011-05-27 19:25:28.000000000 +0100 +++ src/gdb/defs.h 2011-05-27 19:29:26.760790228 +0100 @@ -730,9 +730,6 @@ extern struct command_line *read_command extern void free_command_lines (struct command_line **); -struct thread_info; -struct inferior; - /* String containing the current directory (what getwd would return). */ extern char *current_directory; Index: src/gdb/breakpoint.h =================================================================== --- src.orig/gdb/breakpoint.h 2011-05-27 19:24:06.000000000 +0100 +++ src/gdb/breakpoint.h 2011-05-27 19:30:17.120790237 +0100 @@ -29,6 +29,7 @@ struct value; struct block; struct breakpoint_object; struct get_number_or_range_state; +struct thread_info; /* This is the maximum number of bytes a breakpoint instruction can take. Feel free to increase it. It's just used in a few places to Index: src/gdb/observer.sh =================================================================== --- src.orig/gdb/observer.sh 2011-01-13 15:07:31.000000000 +0000 +++ src/gdb/observer.sh 2011-05-27 19:31:25.280790248 +0100 @@ -64,6 +64,7 @@ struct bpstats; struct so_list; struct objfile; struct thread_info; +struct inferior; EOF ;; esac Index: src/gdb/python/python-internal.h =================================================================== --- src.orig/gdb/python/python-internal.h 2011-03-01 16:00:18.000000000 +0000 +++ src/gdb/python/python-internal.h 2011-05-27 19:35:28.510790291 +0100 @@ -106,6 +106,7 @@ struct value; struct language_defn; struct program_space; struct bpstats; +struct inferior; extern PyObject *gdb_module; extern PyTypeObject value_object_type;