Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Marek Polacek <mpolacek@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb.mi/mi-basics.exp: fix racy tests (PR testsuite/12649)
Date: Wed, 11 May 2011 18:41:00 -0000	[thread overview]
Message-ID: <20110511184053.GA12944@host1.jankratochvil.net> (raw)
In-Reply-To: <4DC42016.5060801@redhat.com>

Hi Marek,

On Fri, 06 May 2011 18:21:42 +0200, Marek Polacek wrote:
> Next, in `test_path_specification' I've only replaced `gdb_test_multiple' with
> `send_gdb'+`gdb_expect'.  I cannot use `mi_gdb_test' here because with this the
> `$expect_out(1,string);' didn't work (unknown variable).

It works with:
    global expect_out

    mi_gdb_test "-environment-path" "\\\^done,path=\"(.*)\"" "environment-path"
    set orig_path $expect_out(3,string)

If not clear the index 1 and 2 is used by mi_gdb_test 2 indexes:
         -re "^($string_regex\[\r\n\]+)?($pattern\[\r\n\]+$mi_gdb_prompt\[ \]*)" {


> 2011-05-06  Marek Polacek  <mpolacek@redhat.com>
> 
>         * gdb.mi/mi-basics.exp: Fix races.  Honour the
>         `test_exec_and_symbol_mi_operatons' return value.
>         (test_mi_interpreter_selection): Use mi_gdb_test instead of
>         gdb_test_multiple.
>         (test_exec_and_symbol_mi_operatons): Likewise.
>         (test_path_specification):  Use send_gdb+gdb_expect instead of
>         gdb_test_multiple.

OK with that change, sorry for the delay.


Thanks,
Jan


  reply	other threads:[~2011-05-11 18:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 16:22 Marek Polacek
2011-05-11 18:41 ` Jan Kratochvil [this message]
2011-05-12  7:14   ` Marek Polacek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110511184053.GA12944@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mpolacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox