From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10705 invoked by alias); 11 May 2011 18:41:28 -0000 Received: (qmail 10696 invoked by uid 22791); 11 May 2011 18:41:27 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 May 2011 18:41:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4BIf9FW022372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 11 May 2011 14:41:09 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4BIexvg008026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 11 May 2011 14:41:07 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p4BIeu56018393; Wed, 11 May 2011 20:40:56 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p4BIerZw018388; Wed, 11 May 2011 20:40:53 +0200 Date: Wed, 11 May 2011 18:41:00 -0000 From: Jan Kratochvil To: Marek Polacek Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb.mi/mi-basics.exp: fix racy tests (PR testsuite/12649) Message-ID: <20110511184053.GA12944@host1.jankratochvil.net> References: <4DC42016.5060801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DC42016.5060801@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00293.txt.bz2 Hi Marek, On Fri, 06 May 2011 18:21:42 +0200, Marek Polacek wrote: > Next, in `test_path_specification' I've only replaced `gdb_test_multiple' with > `send_gdb'+`gdb_expect'. I cannot use `mi_gdb_test' here because with this the > `$expect_out(1,string);' didn't work (unknown variable). It works with: global expect_out mi_gdb_test "-environment-path" "\\\^done,path=\"(.*)\"" "environment-path" set orig_path $expect_out(3,string) If not clear the index 1 and 2 is used by mi_gdb_test 2 indexes: -re "^($string_regex\[\r\n\]+)?($pattern\[\r\n\]+$mi_gdb_prompt\[ \]*)" { > 2011-05-06 Marek Polacek > > * gdb.mi/mi-basics.exp: Fix races. Honour the > `test_exec_and_symbol_mi_operatons' return value. > (test_mi_interpreter_selection): Use mi_gdb_test instead of > gdb_test_multiple. > (test_exec_and_symbol_mi_operatons): Likewise. > (test_path_specification): Use send_gdb+gdb_expect instead of > gdb_test_multiple. OK with that change, sorry for the delay. Thanks, Jan