replace debug_linux_nat_async with debug_linux_nat ?

replace debug_linux_nat_async with debug_linux_nat ?

[Doug Evans]

Hi.
Anyone mind if I delete linux-nat.c:debug_linux_nat_async
and replace it with debug_linux_nat?

I've been in some sessions where I turn the latter on
only to find I also want the former, and from what I read
I pretty much always want both.

Re: replace debug_linux_nat_async with debug_linux_nat ?

[Pedro Alves]

On Tuesday 03 May 2011 21:25:14, Doug Evans wrote:
> Hi.
> Anyone mind if I delete linux-nat.c:debug_linux_nat_async
> and replace it with debug_linux_nat?
> 
> I've been in some sessions where I turn the latter on
> only to find I also want the former, and from what I read
> I pretty much always want both.

It's considerably more noisy, and doesn't help much
sync debugging, but I won't mind.  Especially since
I'd like to flip to async on by default :-)  (needs
fixing some regressions compared to sync mode first though).

Note some tests rely on "set debug lin-lwp", so you'll
most probably need to fix them.

-- 
Pedro Alves

Re: replace debug_linux_nat_async with debug_linux_nat ?

[Tom Tromey]

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> Especially since I'd like to flip to async on by default :-)
Pedro> (needs fixing some regressions compared to sync mode first
Pedro> though).

That sounds great.

Tom

Re: replace debug_linux_nat_async with debug_linux_nat ?

[Doug Evans]

On Tue, May 3, 2011 at 2:34 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Tuesday 03 May 2011 21:25:14, Doug Evans wrote:
>> Hi.
>> Anyone mind if I delete linux-nat.c:debug_linux_nat_async
>> and replace it with debug_linux_nat?
>>
>> I've been in some sessions where I turn the latter on
>> only to find I also want the former, and from what I read
>> I pretty much always want both.
>
> It's considerably more noisy, and doesn't help much
> sync debugging,

I dunno, to each his own for these things I guess.
Plus I'd like to add more and having to think about sync vs async is
time best spent thinking about something else.
I wouldn't mind having different levels of verbosity though.

> but I won't mind.

Thanks.

> Especially since
> I'd like to flip to async on by default

I wonder if sync vs async here is another duality in linux gdb that
can go away at some point.