Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)

[Pedro Alves <pedro@codesourcery.com>]

On Monday 02 May 2011 16:55:27, Jan Kratochvil wrote:
> > In this particular case, since it would be desirable to keep at least one
> > instance of the original form,
> 
> But not required to be in gdb.base/completion.exp .

This is about completion, using one form or the other.
We could move the "\t" form to readline-completion.exp,
but I think a systematic approach to testing all the
completion methods is better, and helps maintenance in the
long run.

> generalization over whole gdb/:
> 
> It is still very strong as the current codebase state is discouraging possible
> contributors keeping the GDB development slow.

I'm not sure how to read that...

> I understand one cannot change the whole codebase to a better / more
> maintainable form over night but when there are attempts and patches offered
> IMO the current codebase should not be actively kept worse.

I took the time investigate the original issues with the code, write a patch
to fix them, explain the problems and the proposed fixes, in order to not keep the
knowledge to myself, and I've posted the beginnings of a patch that cleans
up the test further.  I don't think it's fair to suggest I'm trying to keep
anything worse.

-- 
Pedro Alves