Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Mon, 02 May 2011 17:30:03 +0200, Pedro Alves wrote:
> The "\t" method of completion interacts with readline, the
> "complete command" method doesn't.  I think it's useful and
> important to test the "\t" version, especially since it's
> what CLI users are using.

The question is do we test readline/ or gdb/?

For the readline/ part there is already gdb.base/readline.exp and for the "\t"
interaction there is (soon will be) at least:
	[patch] testsuite: Test readline-6.2 "ask" regression
	http://sourceware.org/ml/gdb-patches/2011-05/msg00002.html
	gdb.base/readline-ask.exp

For the gdb/ part tests I find the "complete" command fully sufficient.


> In this particular case, since it would be desirable to keep at least one
> instance of the original form,

But not required to be in gdb.base/completion.exp .


> And then the original motivation to rewrite
> using a different method disappears or at least diminishes.

generalization over whole gdb/:

It is still very strong as the current codebase state is discouraging possible
contributors keeping the GDB development slow.

I understand one cannot change the whole codebase to a better / more
maintainable form over night but when there are attempts and patches offered
IMO the current codebase should not be actively kept worse.


Thanks,
Jan