From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedro@codesourcery.com (Pedro Alves)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch v2] Re: [commit] Re: [rfc][1/2] Signal delivery + software single-step is broken
Date: Thu, 28 Apr 2011 16:04:00 -0000 [thread overview]
Message-ID: <201104281603.p3SG3uAO015171@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <201104281646.33642.pedro@codesourcery.com> from "Pedro Alves" at Apr 28, 2011 04:46:33 PM
Pedro Alves wrote:
> On Thursday 28 April 2011 16:18:16, Ulrich Weigand wrote:
>
> > Hmm, good point. Indeed I was able to trigger that assert.
> >
> > However, this is easily fixable just the same as in handle_inferior_event:
> > if we already have a step-resume breakpoint, we don't need to insert
> > another one, but just continue running until we hit the original one.
> >
> > Fixed in the patch below, together with a test case that triggers
> > the assert with the original patch.
> >
> > Retested on armv7l-unknown-linux-gnueabi and i386-linux.
> >
> > Does this look OK to you?
>
> Yes, thanks!
Great; thanks again for your thorough review!
I've checked in the patch now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2011-04-28 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 16:43 Ulrich Weigand
2011-04-27 17:17 ` [commit] " Ulrich Weigand
2011-04-27 18:15 ` Pedro Alves
2011-04-27 19:12 ` Ulrich Weigand
2011-04-27 19:44 ` Pedro Alves
2011-04-28 8:55 ` [patch] " Ulrich Weigand
2011-04-28 12:01 ` Pedro Alves
2011-04-28 15:18 ` [patch v2] " Ulrich Weigand
2011-04-28 15:46 ` Pedro Alves
2011-04-28 16:04 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104281603.p3SG3uAO015171@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox