From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22332 invoked by alias); 28 Apr 2011 16:04:21 -0000 Received: (qmail 22324 invoked by uid 22791); 28 Apr 2011 16:04:20 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate4.uk.ibm.com (HELO mtagate4.uk.ibm.com) (194.196.100.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Apr 2011 16:04:05 +0000 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p3SG3wAN008686 for ; Thu, 28 Apr 2011 16:03:58 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p3SG53D51892352 for ; Thu, 28 Apr 2011 17:05:03 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p3SG3vaG015224 for ; Thu, 28 Apr 2011 10:03:57 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p3SG3uAO015171; Thu, 28 Apr 2011 10:03:56 -0600 Message-Id: <201104281603.p3SG3uAO015171@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 28 Apr 2011 18:03:56 +0200 Subject: Re: [patch v2] Re: [commit] Re: [rfc][1/2] Signal delivery + software single-step is broken To: pedro@codesourcery.com (Pedro Alves) Date: Thu, 28 Apr 2011 16:04:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <201104281646.33642.pedro@codesourcery.com> from "Pedro Alves" at Apr 28, 2011 04:46:33 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00545.txt.bz2 Pedro Alves wrote: > On Thursday 28 April 2011 16:18:16, Ulrich Weigand wrote: > > > Hmm, good point. Indeed I was able to trigger that assert. > > > > However, this is easily fixable just the same as in handle_inferior_event: > > if we already have a step-resume breakpoint, we don't need to insert > > another one, but just continue running until we hit the original one. > > > > Fixed in the patch below, together with a test case that triggers > > the assert with the original patch. > > > > Retested on armv7l-unknown-linux-gnueabi and i386-linux. > > > > Does this look OK to you? > > Yes, thanks! Great; thanks again for your thorough review! I've checked in the patch now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com